Title: [207860] trunk
- Revision
- 207860
- Author
- n_w...@apple.com
- Date
- 2016-10-25 18:15:36 -0700 (Tue, 25 Oct 2016)
Log Message
LayoutTest accessibility/mac/meter-gauge-value-description.html failing
https://bugs.webkit.org/show_bug.cgi?id=163997
<rdar://problem/28948637>
Reviewed by Chris Fleizach.
Source/WebCore:
I hand-edited the Localizable.strings file in a previous patch and my changes
were replaced by running update-webkit-localizable-strings script. Changed the
key to be the same as the value to keep consistency with other entries.
Re-enabled the failing test.
* English.lproj/Localizable.strings:
* platform/LocalizedStrings.cpp:
(WebCore::AXMeterGaugeRegionOptimumText):
(WebCore::AXMeterGaugeRegionSuboptimalText):
(WebCore::AXMeterGaugeRegionLessGoodText):
LayoutTests:
* platform/mac/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (207859 => 207860)
--- trunk/LayoutTests/ChangeLog 2016-10-26 01:10:24 UTC (rev 207859)
+++ trunk/LayoutTests/ChangeLog 2016-10-26 01:15:36 UTC (rev 207860)
@@ -1,3 +1,13 @@
+2016-10-25 Nan Wang <n_w...@apple.com>
+
+ LayoutTest accessibility/mac/meter-gauge-value-description.html failing
+ https://bugs.webkit.org/show_bug.cgi?id=163997
+ <rdar://problem/28948637>
+
+ Reviewed by Chris Fleizach.
+
+ * platform/mac/TestExpectations:
+
2016-10-25 Ryan Haddad <ryanhad...@apple.com>
Marking accessibility/mac/meter-gauge-value-description.html as failing on mac.
Modified: trunk/LayoutTests/platform/mac/TestExpectations (207859 => 207860)
--- trunk/LayoutTests/platform/mac/TestExpectations 2016-10-26 01:10:24 UTC (rev 207859)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2016-10-26 01:15:36 UTC (rev 207860)
@@ -1486,5 +1486,3 @@
webkit.org/b/163307 [ Debug ] loader/stateobjects/pushstate-size.html [ Skip ]
webkit.org/b/163307 [ Debug ] loader/stateobjects/replacestate-size-iframe.html [ Skip ]
webkit.org/b/163307 [ Debug ] loader/stateobjects/replacestate-size.html [ Skip ]
-
-webkit.org/b/163997 accessibility/mac/meter-gauge-value-description.html [ Failure ]
Modified: trunk/Source/WebCore/ChangeLog (207859 => 207860)
--- trunk/Source/WebCore/ChangeLog 2016-10-26 01:10:24 UTC (rev 207859)
+++ trunk/Source/WebCore/ChangeLog 2016-10-26 01:15:36 UTC (rev 207860)
@@ -1,3 +1,23 @@
+2016-10-25 Nan Wang <n_w...@apple.com>
+
+ LayoutTest accessibility/mac/meter-gauge-value-description.html failing
+ https://bugs.webkit.org/show_bug.cgi?id=163997
+ <rdar://problem/28948637>
+
+ Reviewed by Chris Fleizach.
+
+ I hand-edited the Localizable.strings file in a previous patch and my changes
+ were replaced by running update-webkit-localizable-strings script. Changed the
+ key to be the same as the value to keep consistency with other entries.
+
+ Re-enabled the failing test.
+
+ * English.lproj/Localizable.strings:
+ * platform/LocalizedStrings.cpp:
+ (WebCore::AXMeterGaugeRegionOptimumText):
+ (WebCore::AXMeterGaugeRegionSuboptimalText):
+ (WebCore::AXMeterGaugeRegionLessGoodText):
+
2016-10-25 Filip Pizlo <fpi...@apple.com>
HeapTimer should not hardcode all of its subclasses and USE(CF) shouldn't be a bizarre special case
Modified: trunk/Source/WebCore/English.lproj/Localizable.strings (207859 => 207860)
--- trunk/Source/WebCore/English.lproj/Localizable.strings 2016-10-26 01:10:24 UTC (rev 207859)
+++ trunk/Source/WebCore/English.lproj/Localizable.strings 2016-10-26 01:15:36 UTC (rev 207860)
@@ -935,7 +935,7 @@
"length required" = "length required";
/* The less good value description for a meter element. */
-"less good" = "less good";
+"critical value" = "critical value";
/* accessibility role description for link */
"link" = "link";
@@ -1022,7 +1022,7 @@
"number of seconds of movie remaining" = "number of seconds of movie remaining";
/* The optimum value description for a meter element. */
-"optimum" = "optimum";
+"optimal value" = "optimal value";
/* accessibility role description for an output element */
"output" = "output";
@@ -1130,7 +1130,7 @@
"stop displaying closed captions" = "stop displaying closed captions";
/* The suboptimal value description for a meter element. */
-"suboptimal" = "suboptimal";
+"suboptimal value" = "suboptimal value";
/* HTTP result code string */
"success" = "success";
Modified: trunk/Source/WebCore/platform/LocalizedStrings.cpp (207859 => 207860)
--- trunk/Source/WebCore/platform/LocalizedStrings.cpp 2016-10-26 01:10:24 UTC (rev 207859)
+++ trunk/Source/WebCore/platform/LocalizedStrings.cpp 2016-10-26 01:15:36 UTC (rev 207860)
@@ -789,17 +789,17 @@
#if ENABLE(METER_ELEMENT)
String AXMeterGaugeRegionOptimumText()
{
- return WEB_UI_STRING("optimum", "The optimum value description for a meter element.");
+ return WEB_UI_STRING("optimal value", "The optimum value description for a meter element.");
}
String AXMeterGaugeRegionSuboptimalText()
{
- return WEB_UI_STRING("suboptimal", "The suboptimal value description for a meter element.");
+ return WEB_UI_STRING("suboptimal value", "The suboptimal value description for a meter element.");
}
String AXMeterGaugeRegionLessGoodText()
{
- return WEB_UI_STRING("less good", "The less good value description for a meter element.");
+ return WEB_UI_STRING("critical value", "The less good value description for a meter element.");
}
#endif // ENABLE(METER_ELEMENT)
#endif // PLATFORM(COCOA)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
