Modified: trunk/Source/_javascript_Core/ChangeLog (208562 => 208563)
--- trunk/Source/_javascript_Core/ChangeLog 2016-11-10 21:40:56 UTC (rev 208562)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-11-10 21:42:33 UTC (rev 208563)
@@ -1,5 +1,24 @@
2016-11-10 Mark Lam <mark....@apple.com>
+ A few bits of minor code clean up.
+ https://bugs.webkit.org/show_bug.cgi?id=164523
+
+ Reviewed by Yusuke Suzuki.
+
+ * interpreter/StackVisitor.cpp:
+ (JSC::StackVisitor::Frame::dump):
+ - Insert a space to make the dump more legible.
+
+ * runtime/Options.h:
+ - Fixed some typos.
+
+ * runtime/StringPrototype.cpp:
+ (JSC::stringProtoFuncReplaceUsingRegExp):
+ (JSC::stringProtoFuncReplaceUsingStringSearch):
+ - Use the VM& that is already available.
+
+2016-11-10 Mark Lam <mark....@apple.com>
+
Graph::methodOfGettingAValueProfileFor() should be returning the profile for the operand node.
https://bugs.webkit.org/show_bug.cgi?id=164600
<rdar://problem/28828676>
Modified: trunk/Source/_javascript_Core/interpreter/StackVisitor.cpp (208562 => 208563)
--- trunk/Source/_javascript_Core/interpreter/StackVisitor.cpp 2016-11-10 21:40:56 UTC (rev 208562)
+++ trunk/Source/_javascript_Core/interpreter/StackVisitor.cpp 2016-11-10 21:42:33 UTC (rev 208563)
@@ -395,7 +395,7 @@
" ", RawPointer(reinterpret_cast<void*>(locationRawBits)), "\n");
out.print(indent, "codeBlock: ", RawPointer(codeBlock));
if (codeBlock)
- out.print(*codeBlock);
+ out.print(" ", *codeBlock);
out.print("\n");
if (codeBlock && !isInlined) {
indent++;
Modified: trunk/Source/_javascript_Core/runtime/Options.h (208562 => 208563)
--- trunk/Source/_javascript_Core/runtime/Options.h 2016-11-10 21:40:56 UTC (rev 208562)
+++ trunk/Source/_javascript_Core/runtime/Options.h 2016-11-10 21:42:33 UTC (rev 208563)
@@ -153,8 +153,8 @@
v(bool, dumpBytecodeAtDFGTime, false, Normal, "dumps bytecode of JS function being DFG compiled") \
v(bool, dumpGraphAfterParsing, false, Normal, nullptr) \
v(bool, dumpGraphAtEachPhase, false, Normal, nullptr) \
- v(bool, dumpDFGGraphAtEachPhase, false, Normal, "dumps the DFG graph at each phase DFG of complitaion (note this excludes DFG graphs during FTL compilation)") \
- v(bool, dumpDFGFTLGraphAtEachPhase, false, Normal, "dumps the DFG graph at each phase DFG of complitaion when compiling FTL code") \
+ v(bool, dumpDFGGraphAtEachPhase, false, Normal, "dumps the DFG graph at each phase of DFG compilation (note this excludes DFG graphs during FTL compilation)") \
+ v(bool, dumpDFGFTLGraphAtEachPhase, false, Normal, "dumps the DFG graph at each phase of DFG compilation when compiling FTL code") \
v(bool, dumpB3GraphAtEachPhase, false, Normal, "dumps the B3 graph at each phase of compilation") \
v(bool, dumpAirGraphAtEachPhase, false, Normal, "dumps the Air graph at each phase of compilation") \
v(bool, verboseDFGByteCodeParsing, false, Normal, nullptr) \
Modified: trunk/Source/_javascript_Core/runtime/StringPrototype.cpp (208562 => 208563)
--- trunk/Source/_javascript_Core/runtime/StringPrototype.cpp 2016-11-10 21:40:56 UTC (rev 208562)
+++ trunk/Source/_javascript_Core/runtime/StringPrototype.cpp 2016-11-10 21:42:33 UTC (rev 208563)
@@ -852,7 +852,7 @@
return JSValue::encode(jsUndefined());
scope.release();
- return replaceUsingRegExpSearch(exec->vm(), exec, string, searchValue, exec->argument(1));
+ return replaceUsingRegExpSearch(vm, exec, string, searchValue, exec->argument(1));
}
EncodedJSValue JSC_HOST_CALL stringProtoFuncReplaceUsingStringSearch(ExecState* exec)
@@ -863,7 +863,7 @@
JSString* string = exec->thisValue().toString(exec);
RETURN_IF_EXCEPTION(scope, encodedJSValue());
- return replaceUsingStringSearch(exec->vm(), exec, string, exec->argument(0), exec->argument(1));
+ return replaceUsingStringSearch(vm, exec, string, exec->argument(0), exec->argument(1));
}
EncodedJSValue JIT_OPERATION operationStringProtoFuncReplaceGeneric(
