Title: [209034] trunk/Source/_javascript_Core
Revision
209034
Author
mark....@apple.com
Date
2016-11-28 15:40:53 -0800 (Mon, 28 Nov 2016)

Log Message

Fix exception scope verification failures in JSDataView.cpp.
https://bugs.webkit.org/show_bug.cgi?id=165020

Reviewed by Saam Barati.

* runtime/JSDataView.cpp:
(JSC::JSDataView::put):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (209033 => 209034)


--- trunk/Source/_javascript_Core/ChangeLog	2016-11-28 23:38:39 UTC (rev 209033)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-11-28 23:40:53 UTC (rev 209034)
@@ -1,5 +1,15 @@
 2016-11-28  Mark Lam  <mark....@apple.com>
 
+        Fix exception scope verification failures in JSDataView.cpp.
+        https://bugs.webkit.org/show_bug.cgi?id=165020
+
+        Reviewed by Saam Barati.
+
+        * runtime/JSDataView.cpp:
+        (JSC::JSDataView::put):
+
+2016-11-28  Mark Lam  <mark....@apple.com>
+
         Fix exception scope verification failures in JSFunction.cpp.
         https://bugs.webkit.org/show_bug.cgi?id=165021
 

Modified: trunk/Source/_javascript_Core/runtime/JSDataView.cpp (209033 => 209034)


--- trunk/Source/_javascript_Core/runtime/JSDataView.cpp	2016-11-28 23:38:39 UTC (rev 209033)
+++ trunk/Source/_javascript_Core/runtime/JSDataView.cpp	2016-11-28 23:40:53 UTC (rev 209034)
@@ -126,13 +126,16 @@
     auto scope = DECLARE_THROW_SCOPE(vm);
     JSDataView* thisObject = jsCast<JSDataView*>(cell);
 
-    if (UNLIKELY(isThisValueAltered(slot, thisObject)))
+    if (UNLIKELY(isThisValueAltered(slot, thisObject))) {
+        scope.release();
         return ordinarySetSlow(exec, thisObject, propertyName, value, slot.thisValue(), slot.isStrictMode());
+    }
 
     if (propertyName == vm.propertyNames->byteLength
         || propertyName == vm.propertyNames->byteOffset)
         return typeError(exec, scope, slot.isStrictMode(), ASCIILiteral("Attempting to write to read-only typed array property."));
 
+    scope.release();
     return Base::put(thisObject, exec, propertyName, value, slot);
 }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to