Title: [210535] trunk/Source/_javascript_Core
Revision
210535
Author
utatane....@gmail.com
Date
2017-01-09 20:19:43 -0800 (Mon, 09 Jan 2017)

Log Message

REGRESSION (r210522): ASSERTION FAILED: divot.offset >= divotStart.offset seen with stress/import-basic.js and stress/import-from-eval.js
https://bugs.webkit.org/show_bug.cgi?id=166873

Reviewed by Saam Barati.

The divot should be the end of `import` token.

* parser/Parser.cpp:
(JSC::Parser<LexerType>::parseMemberExpression):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (210534 => 210535)


--- trunk/Source/_javascript_Core/ChangeLog	2017-01-10 02:17:19 UTC (rev 210534)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-01-10 04:19:43 UTC (rev 210535)
@@ -1,3 +1,15 @@
+2017-01-09  Yusuke Suzuki  <utatane....@gmail.com>
+
+        REGRESSION (r210522): ASSERTION FAILED: divot.offset >= divotStart.offset seen with stress/import-basic.js and stress/import-from-eval.js
+        https://bugs.webkit.org/show_bug.cgi?id=166873
+
+        Reviewed by Saam Barati.
+
+        The divot should be the end of `import` token.
+
+        * parser/Parser.cpp:
+        (JSC::Parser<LexerType>::parseMemberExpression):
+
 2017-01-09  Filip Pizlo  <fpi...@apple.com>
 
         Unreviewed, fix cloop.

Modified: trunk/Source/_javascript_Core/parser/Parser.cpp (210534 => 210535)


--- trunk/Source/_javascript_Core/parser/Parser.cpp	2017-01-10 02:17:19 UTC (rev 210534)
+++ trunk/Source/_javascript_Core/parser/Parser.cpp	2017-01-10 04:19:43 UTC (rev 210535)
@@ -4385,8 +4385,8 @@
             }
         }
     } else if (baseIsImport) {
+        next();
         JSTextPosition expressionEnd = lastTokenEndPosition();
-        next();
         consumeOrFail(OPENPAREN, "import call expects exactly one argument");
         TreeExpression expr = parseAssignmentExpression(context);
         failIfFalse(expr, "Cannot parse _expression_");
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to