Title: [210851] trunk/Source/WebCore
- Revision
- 210851
- Author
- g...@gnome.org
- Date
- 2017-01-18 08:42:46 -0800 (Wed, 18 Jan 2017)
Log Message
[GStreamer] media source tests crashing
https://bugs.webkit.org/show_bug.cgi?id=167158
Reviewed by Carlos Garcia Campos.
This fixes several media source tests which are asserting on debug builds,
such as:
- fast/history/page-cache-removed-source-buffer.html
- imported/w3c/web-platform-tests/media-source/
* platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::AppendPipeline::AppendPipeline): do not adopt the GStPipeline
upon creation. A regular assignment will do the right thing, sinking the
floating ref.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (210850 => 210851)
--- trunk/Source/WebCore/ChangeLog 2017-01-18 13:00:51 UTC (rev 210850)
+++ trunk/Source/WebCore/ChangeLog 2017-01-18 16:42:46 UTC (rev 210851)
@@ -1,3 +1,21 @@
+2017-01-18 Gustavo Noronha Silva <gustavo.noro...@collabora.co.uk>
+
+ [GStreamer] media source tests crashing
+ https://bugs.webkit.org/show_bug.cgi?id=167158
+
+ Reviewed by Carlos Garcia Campos.
+
+ This fixes several media source tests which are asserting on debug builds,
+ such as:
+
+ - fast/history/page-cache-removed-source-buffer.html
+ - imported/w3c/web-platform-tests/media-source/
+
+ * platform/graphics/gstreamer/mse/AppendPipeline.cpp:
+ (WebCore::AppendPipeline::AppendPipeline): do not adopt the GStPipeline
+ upon creation. A regular assignment will do the right thing, sinking the
+ floating ref.
+
2017-01-18 Antoine Quint <grao...@apple.com>
[Modern Media Controls] Turn modern media controls on by default
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp (210850 => 210851)
--- trunk/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp 2017-01-18 13:00:51 UTC (rev 210850)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp 2017-01-18 16:42:46 UTC (rev 210851)
@@ -107,7 +107,7 @@
// FIXME: give a name to the pipeline, maybe related with the track it's managing.
// The track name is still unknown at this time, though.
- m_pipeline = adoptGRef(gst_pipeline_new(nullptr));
+ m_pipeline = gst_pipeline_new(nullptr);
m_bus = adoptGRef(gst_pipeline_get_bus(GST_PIPELINE(m_pipeline.get())));
gst_bus_add_signal_watch(m_bus.get());
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
