Title: [213276] trunk/Source/WebCore
- Revision
- 213276
- Author
- carlo...@webkit.org
- Date
- 2017-03-02 03:44:41 -0800 (Thu, 02 Mar 2017)
Log Message
[GTK] Crash in WebCore::CoordinatedGraphicsLayer::notifyFlushRequired
https://bugs.webkit.org/show_bug.cgi?id=166420
Reviewed by Žan Doberšek.
This is happening when closing a page that is being inspected. When CoordinatedGraphicsLayer::removeFromParent()
is called, the coordinator has already been invalidated, so all its layers were set a nullptr coordinator. I
think it's safe to simply handle m_coordinator being nullptr in notifyFlushRequired().
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::notifyFlushRequired): Return early if the coordinator is nullptr.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (213275 => 213276)
--- trunk/Source/WebCore/ChangeLog 2017-03-02 09:43:18 UTC (rev 213275)
+++ trunk/Source/WebCore/ChangeLog 2017-03-02 11:44:41 UTC (rev 213276)
@@ -1,3 +1,17 @@
+2017-03-02 Carlos Garcia Campos <cgar...@igalia.com>
+
+ [GTK] Crash in WebCore::CoordinatedGraphicsLayer::notifyFlushRequired
+ https://bugs.webkit.org/show_bug.cgi?id=166420
+
+ Reviewed by Žan Doberšek.
+
+ This is happening when closing a page that is being inspected. When CoordinatedGraphicsLayer::removeFromParent()
+ is called, the coordinator has already been invalidated, so all its layers were set a nullptr coordinator. I
+ think it's safe to simply handle m_coordinator being nullptr in notifyFlushRequired().
+
+ * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
+ (WebCore::CoordinatedGraphicsLayer::notifyFlushRequired): Return early if the coordinator is nullptr.
+
2017-03-02 Andreas Kling <akl...@apple.com>
Don't keep dead resources in MemoryCache while under memory pressure.
Modified: trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp (213275 => 213276)
--- trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp 2017-03-02 09:43:18 UTC (rev 213275)
+++ trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp 2017-03-02 11:44:41 UTC (rev 213276)
@@ -53,7 +53,9 @@
void CoordinatedGraphicsLayer::notifyFlushRequired()
{
- ASSERT(m_coordinator);
+ if (!m_coordinator)
+ return;
+
if (m_coordinator->isFlushingLayerChanges())
return;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
