Title: [213979] trunk/LayoutTests
Revision
213979
Author
commit-qu...@webkit.org
Date
2017-03-15 03:19:04 -0700 (Wed, 15 Mar 2017)

Log Message

[mac-wk1 debug] LayoutTest media/modern-media-controls/airplay-placard/airplay-placard-text-section.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=169654
<rdar://problem/31059092>

Patch by Antoine Quint <grao...@apple.com> on 2017-03-15
Reviewed by Dean Jackson.

Using an asynchronous assertion to improve reliability.

* media/modern-media-controls/airplay-placard/airplay-placard-text-section-expected.txt:
* media/modern-media-controls/airplay-placard/airplay-placard-text-section.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (213978 => 213979)


--- trunk/LayoutTests/ChangeLog	2017-03-15 09:51:49 UTC (rev 213978)
+++ trunk/LayoutTests/ChangeLog	2017-03-15 10:19:04 UTC (rev 213979)
@@ -1,3 +1,16 @@
+2017-03-15  Antoine Quint  <grao...@apple.com>
+
+        [mac-wk1 debug] LayoutTest media/modern-media-controls/airplay-placard/airplay-placard-text-section.html is a flaky timeout
+        https://bugs.webkit.org/show_bug.cgi?id=169654
+        <rdar://problem/31059092>
+
+        Reviewed by Dean Jackson.
+
+        Using an asynchronous assertion to improve reliability.
+
+        * media/modern-media-controls/airplay-placard/airplay-placard-text-section-expected.txt:
+        * media/modern-media-controls/airplay-placard/airplay-placard-text-section.html:
+
 2017-03-14  Youenn Fablet  <you...@apple.com>
 
         CanvasCapture should not generate a frame per each canvas draw command

Modified: trunk/LayoutTests/media/modern-media-controls/airplay-placard/airplay-placard-text-section-expected.txt (213978 => 213979)


--- trunk/LayoutTests/media/modern-media-controls/airplay-placard/airplay-placard-text-section-expected.txt	2017-03-15 09:51:49 UTC (rev 213978)
+++ trunk/LayoutTests/media/modern-media-controls/airplay-placard/airplay-placard-text-section-expected.txt	2017-03-15 10:19:04 UTC (rev 213979)
@@ -3,6 +3,7 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
+PASS !!document.querySelector('.placard') became true
 PASS window.getComputedStyle(document.querySelector('.title')).webkitUserSelect is "none"
 PASS window.getComputedStyle(document.querySelector('.title')).cursor is "default"
 PASS window.getComputedStyle(document.querySelector('.description')).webkitUserSelect is "none"

Modified: trunk/LayoutTests/media/modern-media-controls/airplay-placard/airplay-placard-text-section.html (213978 => 213979)


--- trunk/LayoutTests/media/modern-media-controls/airplay-placard/airplay-placard-text-section.html	2017-03-15 09:51:49 UTC (rev 213978)
+++ trunk/LayoutTests/media/modern-media-controls/airplay-placard/airplay-placard-text-section.html	2017-03-15 10:19:04 UTC (rev 213979)
@@ -12,8 +12,7 @@
 mediaControls.showPlacard(mediaControls.airplayPlacard);
 document.body.appendChild(mediaControls.element);
 
-scheduler.frameDidFire = function()
-{
+shouldBecomeEqual("!!document.querySelector('.placard')", "true", () => {
     shouldBeEqualToString("window.getComputedStyle(document.querySelector('.title')).webkitUserSelect", "none");
     shouldBeEqualToString("window.getComputedStyle(document.querySelector('.title')).cursor", "default");
     shouldBeEqualToString("window.getComputedStyle(document.querySelector('.description')).webkitUserSelect", "none");
@@ -21,8 +20,8 @@
 
     mediaControls.element.remove();
     debug("");
-    finishMediaControlsTest();
-};
+    finishJSTest();
+});
 
 </script>
 <script src=""
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to