Title: [213989] trunk/Source/WebCore
Revision
213989
Author
zandober...@gmail.com
Date
2017-03-15 11:02:07 -0700 (Wed, 15 Mar 2017)

Log Message

[TexMap] Add missing class member initializations
https://bugs.webkit.org/show_bug.cgi?id=169665

Reviewed by Michael Catanzaro.

Zero-initialize the members in various TextureMapper classes
that are missing the proper initialization, as reported by
the Coverity tool.

* platform/graphics/texmap/BitmapTexturePool.h:
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
* platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:
(WebCore::CoordinatedGraphicsLayerState::CoordinatedGraphicsLayerState):
* platform/graphics/texmap/coordinated/SurfaceUpdateInfo.h:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (213988 => 213989)


--- trunk/Source/WebCore/ChangeLog	2017-03-15 17:59:08 UTC (rev 213988)
+++ trunk/Source/WebCore/ChangeLog	2017-03-15 18:02:07 UTC (rev 213989)
@@ -1,3 +1,20 @@
+2017-03-15  Zan Dobersek  <zdober...@igalia.com>
+
+        [TexMap] Add missing class member initializations
+        https://bugs.webkit.org/show_bug.cgi?id=169665
+
+        Reviewed by Michael Catanzaro.
+
+        Zero-initialize the members in various TextureMapper classes
+        that are missing the proper initialization, as reported by
+        the Coverity tool.
+
+        * platform/graphics/texmap/BitmapTexturePool.h:
+        * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
+        * platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:
+        (WebCore::CoordinatedGraphicsLayerState::CoordinatedGraphicsLayerState):
+        * platform/graphics/texmap/coordinated/SurfaceUpdateInfo.h:
+
 2017-03-15  Alex Christensen  <achristen...@webkit.org>
 
         Compiled content extensions should include the JSON source

Modified: trunk/Source/WebCore/platform/graphics/texmap/BitmapTexturePool.h (213988 => 213989)


--- trunk/Source/WebCore/platform/graphics/texmap/BitmapTexturePool.h	2017-03-15 17:59:08 UTC (rev 213988)
+++ trunk/Source/WebCore/platform/graphics/texmap/BitmapTexturePool.h	2017-03-15 18:02:07 UTC (rev 213989)
@@ -59,7 +59,7 @@
         void markIsInUse() { m_lastUsedTime = monotonicallyIncreasingTime(); }
 
         RefPtr<BitmapTexture> m_texture;
-        double m_lastUsedTime;
+        double m_lastUsedTime { 0.0 };
     };
 
     void scheduleReleaseUnusedTextures();

Modified: trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h (213988 => 213989)


--- trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h	2017-03-15 17:59:08 UTC (rev 213988)
+++ trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h	2017-03-15 18:02:07 UTC (rev 213989)
@@ -232,7 +232,7 @@
     PlatformLayer* m_platformLayer;
     Timer m_animationStartedTimer;
     TextureMapperAnimations m_animations;
-    double m_lastAnimationStartTime;
+    double m_lastAnimationStartTime { 0.0 };
 
     ScrollableArea* m_scrollableArea;
 };

Modified: trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h (213988 => 213989)


--- trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h	2017-03-15 17:59:08 UTC (rev 213988)
+++ trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h	2017-03-15 18:02:07 UTC (rev 213989)
@@ -126,6 +126,7 @@
         , replica(InvalidCoordinatedLayerID)
         , mask(InvalidCoordinatedLayerID)
         , imageID(InvalidCoordinatedImageBackingID)
+        , repaintCount(0)
 #if USE(COORDINATED_GRAPHICS_THREADED)
         , platformLayerProxy(0)
 #endif

Modified: trunk/Source/WebCore/platform/graphics/texmap/coordinated/SurfaceUpdateInfo.h (213988 => 213989)


--- trunk/Source/WebCore/platform/graphics/texmap/coordinated/SurfaceUpdateInfo.h	2017-03-15 17:59:08 UTC (rev 213988)
+++ trunk/Source/WebCore/platform/graphics/texmap/coordinated/SurfaceUpdateInfo.h	2017-03-15 18:02:07 UTC (rev 213989)
@@ -35,7 +35,7 @@
     IntRect updateRect;
 
     // The id of the update atlas including the shareable bitmap containing the updates.
-    uint32_t atlasID;
+    uint32_t atlasID { 0 };
 
     // The offset in the bitmap where the rendered contents are.
     IntPoint surfaceOffset;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to