Title: [214497] trunk/Tools
- Revision
- 214497
- Author
- aakash_j...@apple.com
- Date
- 2017-03-28 15:14:49 -0700 (Tue, 28 Mar 2017)
Log Message
Fix Dashboard test _presentPopoverForJavaScriptCoreTestRegressions
https://bugs.webkit.org/show_bug.cgi?id=170193
Reviewed by Alexey Proskuryakov.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
Fixed the order of arguments.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js (214496 => 214497)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js 2017-03-28 21:56:10 UTC (rev 214496)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js 2017-03-28 22:14:49 UTC (rev 214497)
@@ -324,7 +324,7 @@
iteration._javascript_CoreTestResults = new MockBuildbotTestResults();
var view = new BuildbotQueueView();
- view._presentPopoverForJavaScriptCoreTestRegressions(element, popover, iteration, "jscore-test");
+ view._presentPopoverForJavaScriptCoreTestRegressions("jscore-test", element, popover, iteration);
JSON.load("resources/test-jsc-results.json", function(data)
{
@@ -368,7 +368,7 @@
iteration._javascript_CoreTestResults = {"regressions": ["uno", "dos", "tres"]};
var view = new BuildbotQueueView();
- view._presentPopoverForJavaScriptCoreTestRegressions(element, popover, iteration, "jscore-test");
+ view._presentPopoverForJavaScriptCoreTestRegressions("jscore-test", element, popover, iteration);
var numChildrenInEmptyPopoverContent = 2;
strictEqual(popover._content.childNodes.length - numChildrenInEmptyPopoverContent,
Modified: trunk/Tools/ChangeLog (214496 => 214497)
--- trunk/Tools/ChangeLog 2017-03-28 21:56:10 UTC (rev 214496)
+++ trunk/Tools/ChangeLog 2017-03-28 22:14:49 UTC (rev 214497)
@@ -1,5 +1,15 @@
2017-03-28 Aakash Jain <aakash_j...@apple.com>
+ Fix Dashboard test _presentPopoverForJavaScriptCoreTestRegressions
+ https://bugs.webkit.org/show_bug.cgi?id=170193
+
+ Reviewed by Alexey Proskuryakov.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
+ Fixed the order of arguments.
+
+2017-03-28 Aakash Jain <aakash_j...@apple.com>
+
Dashboard tests fails to fetch the revision from commits
https://bugs.webkit.org/show_bug.cgi?id=170191
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
