Title: [214540] trunk/Source/WebCore
- Revision
- 214540
- Author
- commit-qu...@webkit.org
- Date
- 2017-03-29 10:08:23 -0700 (Wed, 29 Mar 2017)
Log Message
[Modern Media Controls] Volume slider is initially empty
https://bugs.webkit.org/show_bug.cgi?id=170237
<rdar://problem/31319077>
Patch by Antoine Quint <grao...@apple.com> on 2017-03-29
Reviewed by Dean Jackson.
Fixing fallout from https://bugs.webkit.org/show_bug.cgi?id=167935 where we changed the behavior
of layout() to happen prior to a commit. In this one instance, we were overriding layout() to run
after a commit, so we now override commit(). Otherwise, the <canvas> that we draw the volume slider
into would have its "width" and "height" properties set after we drew, which would clear the <canvas>.
* Modules/modern-media-controls/controls/slider.js:
(Slider.prototype.commit):
(Slider.prototype.layout): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (214539 => 214540)
--- trunk/Source/WebCore/ChangeLog 2017-03-29 17:08:08 UTC (rev 214539)
+++ trunk/Source/WebCore/ChangeLog 2017-03-29 17:08:23 UTC (rev 214540)
@@ -1,3 +1,20 @@
+2017-03-29 Antoine Quint <grao...@apple.com>
+
+ [Modern Media Controls] Volume slider is initially empty
+ https://bugs.webkit.org/show_bug.cgi?id=170237
+ <rdar://problem/31319077>
+
+ Reviewed by Dean Jackson.
+
+ Fixing fallout from https://bugs.webkit.org/show_bug.cgi?id=167935 where we changed the behavior
+ of layout() to happen prior to a commit. In this one instance, we were overriding layout() to run
+ after a commit, so we now override commit(). Otherwise, the <canvas> that we draw the volume slider
+ into would have its "width" and "height" properties set after we drew, which would clear the <canvas>.
+
+ * Modules/modern-media-controls/controls/slider.js:
+ (Slider.prototype.commit):
+ (Slider.prototype.layout): Deleted.
+
2017-03-29 Zan Dobersek <zdober...@igalia.com>
[GCrypt] Move over empty GnuTLS-based SUBTLE_CRYPTO implementation files
Modified: trunk/Source/WebCore/Modules/modern-media-controls/controls/slider.js (214539 => 214540)
--- trunk/Source/WebCore/Modules/modern-media-controls/controls/slider.js 2017-03-29 17:08:08 UTC (rev 214539)
+++ trunk/Source/WebCore/Modules/modern-media-controls/controls/slider.js 2017-03-29 17:08:23 UTC (rev 214540)
@@ -98,9 +98,9 @@
}
}
- layout()
+ commit()
{
- super.layout();
+ super.commit();
this.draw(this._canvas.element.getContext("2d"));
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
