Title: [214820] trunk/LayoutTests
Revision
214820
Author
commit-qu...@webkit.org
Date
2017-04-03 11:00:06 -0700 (Mon, 03 Apr 2017)

Log Message

LayoutTest pointer-lock/mouse-event-delivery.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=167965

Patch by Jeremy Jones <jere...@apple.com> on 2017-04-03
Reviewed by Jon Lee.

Wait for wheel event before doing next step of test. The wheel event is delivered asynchronously and
can therefore be delivered later than expected by the test. This is already done for the first one,
do this for the second one also.

* platform/mac-wk2/TestExpectations:
* pointer-lock/mouse-event-delivery.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (214819 => 214820)


--- trunk/LayoutTests/ChangeLog	2017-04-03 17:51:29 UTC (rev 214819)
+++ trunk/LayoutTests/ChangeLog	2017-04-03 18:00:06 UTC (rev 214820)
@@ -1,3 +1,17 @@
+2017-04-03  Jeremy Jones  <jere...@apple.com>
+
+        LayoutTest pointer-lock/mouse-event-delivery.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=167965
+
+        Reviewed by Jon Lee.
+
+        Wait for wheel event before doing next step of test. The wheel event is delivered asynchronously and
+        can therefore be delivered later than expected by the test. This is already done for the first one,
+        do this for the second one also.
+
+        * platform/mac-wk2/TestExpectations:
+        * pointer-lock/mouse-event-delivery.html:
+
 2017-04-01  Simon Fraser  <simon.fra...@apple.com>
 
         Clean up touch event handler registration when moving nodes between documents

Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (214819 => 214820)


--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2017-04-03 17:51:29 UTC (rev 214819)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2017-04-03 18:00:06 UTC (rev 214820)
@@ -619,8 +619,6 @@
 
 webkit.org/b/167538 [ Sierra ] fast/css-grid-layout/grid-simplified-layout-positioned.html [ Pass ImageOnlyFailure ]
 
-webkit.org/b/167965 pointer-lock/mouse-event-delivery.html [ Pass Failure ]
-
 webkit.org/b/168235 [ Debug ] imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-download-click.html [ Pass Failure ]
 
 webkit.org/b/168085 tiled-drawing/scrolling/latched-to-deleted-node.html [ Pass Failure ]

Modified: trunk/LayoutTests/pointer-lock/mouse-event-delivery.html (214819 => 214820)


--- trunk/LayoutTests/pointer-lock/mouse-event-delivery.html	2017-04-03 17:51:29 UTC (rev 214819)
+++ trunk/LayoutTests/pointer-lock/mouse-event-delivery.html	2017-04-03 18:00:06 UTC (rev 214820)
@@ -96,13 +96,12 @@
         function () {
             debug("     With a lock in place send a wheel event.")
             targetdiv1._onwheel_ = eventNotExpected;
-            targetdiv2._onwheel_ = eventExpected;
+            targetdiv2._onwheel_ = eventExpectedThenNextStep;
             document.body._onwheel_ = eventExpected;
             if (window.eventSender) {
                 window.eventSender.leapForward(1000);
                 window.eventSender.mouseScrollBy(0,10);
             }
-            doNextStep();
         },
         function () {
             debug("     With a lock in place send a click.")
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to