Title: [214862] trunk/Source/WebInspectorUI
- Revision
- 214862
- Author
- bb...@apple.com
- Date
- 2017-04-03 20:20:28 -0700 (Mon, 03 Apr 2017)
Log Message
Web Inspector: RTL: hierarchical path component labels should guess directionality based on content
https://bugs.webkit.org/show_bug.cgi?id=170298
Reviewed by Timothy Hatcher.
* UserInterface/Views/HierarchicalPathComponent.js:
(WebInspector.HierarchicalPathComponent):
Use dir="auto" since this will properly set 'unicode-bidi:isolate' for form elements too.
This is applied to the title label and to the <select> for the path component.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (214861 => 214862)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-04-04 03:19:09 UTC (rev 214861)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-04-04 03:20:28 UTC (rev 214862)
@@ -1,3 +1,15 @@
+2017-04-03 Brian Burg <bb...@apple.com>
+
+ Web Inspector: RTL: hierarchical path component labels should guess directionality based on content
+ https://bugs.webkit.org/show_bug.cgi?id=170298
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/HierarchicalPathComponent.js:
+ (WebInspector.HierarchicalPathComponent):
+ Use dir="auto" since this will properly set 'unicode-bidi:isolate' for form elements too.
+ This is applied to the title label and to the <select> for the path component.
+
2017-04-03 Matt Baker <mattba...@apple.com>
Web Inspector: Show additional pause reason details for DOM "subtree modified" breakpoint
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.js (214861 => 214862)
--- trunk/Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.js 2017-04-04 03:19:09 UTC (rev 214861)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.js 2017-04-04 03:20:28 UTC (rev 214862)
@@ -51,6 +51,7 @@
this._titleElement = document.createElement("div");
this._titleElement.className = "title";
+ this._titleElement.setAttribute("dir", "auto");
this._element.appendChild(this._titleElement);
this._titleContentElement = document.createElement("div");
@@ -62,6 +63,7 @@
this._element.appendChild(this._separatorElement);
this._selectElement = document.createElement("select");
+ this._selectElement.setAttribute("dir", "auto");
this._selectElement.addEventListener("mouseover", this._selectElementMouseOver.bind(this));
this._selectElement.addEventListener("mouseout", this._selectElementMouseOut.bind(this));
this._selectElement.addEventListener("mousedown", this._selectElementMouseDown.bind(this));
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
