Title: [215078] trunk/Source/WebKit2
- Revision
- 215078
- Author
- joep...@webkit.org
- Date
- 2017-04-06 17:39:43 -0700 (Thu, 06 Apr 2017)
Log Message
Web Inspector: Hangs when loading under SpeculativeLoad::shouldCaptureExtraNetworkLoadMetrics
https://bugs.webkit.org/show_bug.cgi?id=170575
Rubber-stamped by Brian Burg.
* NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:
(WebKit::NetworkCache::SpeculativeLoad::shouldCaptureExtraNetworkLoadMetrics): Deleted.
* NetworkProcess/cache/NetworkCacheSpeculativeLoad.h:
m_networkLoad is a wrapper around `this` as the client, so we would infinite loop here.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (215077 => 215078)
--- trunk/Source/WebKit2/ChangeLog 2017-04-07 00:39:24 UTC (rev 215077)
+++ trunk/Source/WebKit2/ChangeLog 2017-04-07 00:39:43 UTC (rev 215078)
@@ -1,3 +1,15 @@
+2017-04-06 Joseph Pecoraro <pecor...@apple.com>
+
+ Web Inspector: Hangs when loading under SpeculativeLoad::shouldCaptureExtraNetworkLoadMetrics
+ https://bugs.webkit.org/show_bug.cgi?id=170575
+
+ Rubber-stamped by Brian Burg.
+
+ * NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:
+ (WebKit::NetworkCache::SpeculativeLoad::shouldCaptureExtraNetworkLoadMetrics): Deleted.
+ * NetworkProcess/cache/NetworkCacheSpeculativeLoad.h:
+ m_networkLoad is a wrapper around `this` as the client, so we would infinite loop here.
+
2017-04-06 Commit Queue <commit-qu...@webkit.org>
Unreviewed, rolling out r214973.
Modified: trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp (215077 => 215078)
--- trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp 2017-04-07 00:39:24 UTC (rev 215077)
+++ trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp 2017-04-07 00:39:43 UTC (rev 215078)
@@ -156,13 +156,6 @@
m_completionHandler(WTFMove(m_cacheEntry));
}
-#if USE(NETWORK_SESSION)
-bool SpeculativeLoad::shouldCaptureExtraNetworkLoadMetrics() const
-{
- return m_networkLoad->shouldCaptureExtraNetworkLoadMetrics();
-}
-#endif
-
} // namespace NetworkCache
} // namespace WebKit
Modified: trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoad.h (215077 => 215078)
--- trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoad.h 2017-04-07 00:39:24 UTC (rev 215077)
+++ trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoad.h 2017-04-07 00:39:43 UTC (rev 215078)
@@ -64,10 +64,6 @@
void didFinishLoading(const WebCore::NetworkLoadMetrics&) override;
void didFailLoading(const WebCore::ResourceError&) override;
-#if USE(NETWORK_SESSION)
- bool shouldCaptureExtraNetworkLoadMetrics() const override;
-#endif
-
void didComplete();
GlobalFrameID m_frameID;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
