Title: [215764] trunk/LayoutTests
Revision
215764
Author
cdu...@apple.com
Date
2017-04-25 14:41:31 -0700 (Tue, 25 Apr 2017)

Log Message

Element.dataset.name incorrectly returns undefined
https://bugs.webkit.org/show_bug.cgi?id=161454
<rdar://problem/31818563>

Reviewed by Mark Lam.

Add layout test for JS caching bug on DOMStringMap that was fixed as part
of a large named property getter refactoring in r210667.

* fast/dom/dataset-caching-bug-expected.txt: Added.
* fast/dom/dataset-caching-bug.html: Added.

Modified Paths

Added Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (215763 => 215764)


--- trunk/LayoutTests/ChangeLog	2017-04-25 21:36:21 UTC (rev 215763)
+++ trunk/LayoutTests/ChangeLog	2017-04-25 21:41:31 UTC (rev 215764)
@@ -1,3 +1,17 @@
+2017-04-25  Chris Dumez  <cdu...@apple.com>
+
+        Element.dataset.name incorrectly returns undefined
+        https://bugs.webkit.org/show_bug.cgi?id=161454
+        <rdar://problem/31818563>
+
+        Reviewed by Mark Lam.
+
+        Add layout test for JS caching bug on DOMStringMap that was fixed as part
+        of a large named property getter refactoring in r210667.
+
+        * fast/dom/dataset-caching-bug-expected.txt: Added.
+        * fast/dom/dataset-caching-bug.html: Added.
+
 2017-04-25  Myles C. Maxfield  <mmaxfi...@apple.com>
 
         Supplementary Multilingual Plane Complex Scripts Rendered Incorrectly

Added: trunk/LayoutTests/fast/dom/dataset-caching-bug-expected.txt (0 => 215764)


--- trunk/LayoutTests/fast/dom/dataset-caching-bug-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/fast/dom/dataset-caching-bug-expected.txt	2017-04-25 21:41:31 UTC (rev 215764)
@@ -0,0 +1,10 @@
+Tests for a caching bug on DOMStringMap causing us to return an outdated value.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS The bug did not reproduce.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+

Added: trunk/LayoutTests/fast/dom/dataset-caching-bug.html (0 => 215764)


--- trunk/LayoutTests/fast/dom/dataset-caching-bug.html	                        (rev 0)
+++ trunk/LayoutTests/fast/dom/dataset-caching-bug.html	2017-04-25 21:41:31 UTC (rev 215764)
@@ -0,0 +1,35 @@
+<!DOCTYPE html>
+<html>
+<body>
+<script src=""
+<div id="user"></div>
+<script>
+description("Tests for a caching bug on DOMStringMap causing us to return an outdated value.");
+
+const div = document.getElementById("user");
+let success = true;
+for (var i = 0; i < 100000; ++i) {
+    if (i == 90000)
+        div.setAttribute("data-test", "value");
+
+    if (!div.dataset.test) {
+        if (i >= 90000) {
+            testFailed("div.dataset.test returned undefined but should not have");
+            success = false;
+            break;
+        }
+    } else {
+        if (i < 90000) {
+            testFailed("div.dataset.test did not return undefined but should have");
+            success = false;
+            break;
+        }
+    }
+}
+
+if (success)
+    testPassed("The bug did not reproduce.");
+</script>
+<script src=""
+</body>
+</html>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to