Title: [215863] trunk/LayoutTests
Revision
215863
Author
commit-qu...@webkit.org
Date
2017-04-27 08:01:34 -0700 (Thu, 27 Apr 2017)

Log Message

Fix some tests from platform-tests/cssom-view/cssom-view/
https://bugs.webkit.org/show_bug.cgi?id=171228

Patch by Frederic Wang <fw...@igalia.com> on 2017-04-27
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Fixes for some tests are imported from the web-platform-test repository.
Expectations are updated accordingly.

* web-platform-tests/cssom-view/cssom-view/media-query-list-interface-expected.txt: Added.
* web-platform-tests/cssom-view/cssom-view/media-query-list-interface.xht:
* web-platform-tests/cssom-view/cssom-view/window-interface-expected.txt:
* web-platform-tests/cssom-view/cssom-view/window-interface.xht:

LayoutTests:

* TestExpectations: Unskip media-query-list-interface.

Modified Paths

Added Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (215862 => 215863)


--- trunk/LayoutTests/ChangeLog	2017-04-27 12:28:46 UTC (rev 215862)
+++ trunk/LayoutTests/ChangeLog	2017-04-27 15:01:34 UTC (rev 215863)
@@ -1,3 +1,12 @@
+2017-04-27  Frederic Wang  <fw...@igalia.com>
+
+        Fix some tests from platform-tests/cssom-view/cssom-view/
+        https://bugs.webkit.org/show_bug.cgi?id=171228
+
+        Reviewed by Youenn Fablet.
+
+        * TestExpectations: Unskip media-query-list-interface.
+
 2017-04-27  Zalan Bujtas  <za...@apple.com>
 
         Text gets cut off when bailing out of simple line layout with widows.

Modified: trunk/LayoutTests/TestExpectations (215862 => 215863)


--- trunk/LayoutTests/TestExpectations	2017-04-27 12:28:46 UTC (rev 215862)
+++ trunk/LayoutTests/TestExpectations	2017-04-27 15:01:34 UTC (rev 215863)
@@ -1267,7 +1267,6 @@
 webkit.org/b/153137 imported/w3c/web-platform-tests/cssom-view/elementsFromPoint.html [ Skip ]
 webkit.org/b/5991 imported/w3c/web-platform-tests/cssom-view/scrollingElement.html [ Skip ]
 webkit.org/b/171226 imported/w3c/web-platform-tests/cssom-view/cssom-getBoundingClientRect-002.html [ Skip ]
-webkit.org/b/171228 imported/w3c/web-platform-tests/cssom-view/cssom-view/media-query-list-interface.xht [ Skip ]
 
 ### END OF -disabled tests
 ########################################

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (215862 => 215863)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2017-04-27 12:28:46 UTC (rev 215862)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2017-04-27 15:01:34 UTC (rev 215863)
@@ -1,3 +1,18 @@
+2017-04-27  Frederic Wang  <fw...@igalia.com>
+
+        Fix some tests from platform-tests/cssom-view/cssom-view/
+        https://bugs.webkit.org/show_bug.cgi?id=171228
+
+        Reviewed by Youenn Fablet.
+
+        Fixes for some tests are imported from the web-platform-test repository.
+        Expectations are updated accordingly.
+
+        * web-platform-tests/cssom-view/cssom-view/media-query-list-interface-expected.txt: Added.
+        * web-platform-tests/cssom-view/cssom-view/media-query-list-interface.xht:
+        * web-platform-tests/cssom-view/cssom-view/window-interface-expected.txt:
+        * web-platform-tests/cssom-view/cssom-view/window-interface.xht:
+
 2017-04-26  Saam Barati  <sbar...@apple.com>
 
         ASSERTION FAILED: inIndex != notFound in JSC::invalidParameterInSourceAppender()

Added: trunk/LayoutTests/imported/w3c/web-platform-tests/cssom-view/cssom-view/media-query-list-interface-expected.txt (0 => 215863)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/cssom-view/cssom-view/media-query-list-interface-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/cssom-view/cssom-view/media-query-list-interface-expected.txt	2017-04-27 15:01:34 UTC (rev 215863)
@@ -0,0 +1,7 @@
+
+PASS window_exposes_matchmedia 
+PASS mediaquerylist_inherited_functions 
+PASS mediaquerylist_functions 
+PASS mediaquerylist_properties 
+PASS mediaquerylist_properties_readonly 
+

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/cssom-view/cssom-view/media-query-list-interface.xht (215862 => 215863)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/cssom-view/cssom-view/media-query-list-interface.xht	2017-04-27 12:28:46 UTC (rev 215862)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/cssom-view/cssom-view/media-query-list-interface.xht	2017-04-27 15:01:34 UTC (rev 215863)
@@ -18,10 +18,10 @@
             var mediaQueryList;
             test(
                 function(){
-                    assert_inherits(window, "matchMedia");
+                    assert_own_property(window, "matchMedia");
                     mediaQueryList = window.matchMedia('foo');
-                }, 'window_inherits_matchmedia', {
-                  assert: ['window.matchMedia is inherited. If this fails, the rest of the test fails.']
+                }, 'window_exposes_matchmedia', {
+                  assert: ['window.matchMedia is exposed by window. If this fails, the rest of the test fails.']
                 }
             );
             /*
@@ -50,10 +50,10 @@
              */
             test(
                 function() {
-                    assert_own_property(mediaQueryList, 'media');
-                    assert_own_property(mediaQueryList, 'matches');
+                    assert_inherits(mediaQueryList, 'media');
+                    assert_inherits(mediaQueryList, 'matches');
                 }, 'mediaquerylist_properties', {
-                  assert: ['MediaQueryList properties are owned by window']
+                  assert: ['MediaQueryList properties are inherited']
                 }
             );
             test(

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/cssom-view/cssom-view/window-interface-expected.txt (215862 => 215863)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/cssom-view/cssom-view/window-interface-expected.txt	2017-04-27 12:28:46 UTC (rev 215862)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/cssom-view/cssom-view/window-interface-expected.txt	2017-04-27 15:01:34 UTC (rev 215863)
@@ -1,5 +1,5 @@
 
-FAIL window_inherited_functions assert_inherits: property "matchMedia" found on object expected in prototype chain
+PASS window_exposed_functions 
 PASS window_functions 
 PASS window_properties 
 FAIL window_properties_readonly assert_readonly: changing property "screen" succeeded

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/cssom-view/cssom-view/window-interface.xht (215862 => 215863)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/cssom-view/cssom-view/window-interface.xht	2017-04-27 12:28:46 UTC (rev 215862)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/cssom-view/cssom-view/window-interface.xht	2017-04-27 15:01:34 UTC (rev 215863)
@@ -15,8 +15,8 @@
         <div id="log" />
         <script id="metadata_cache">/*
         {
-          "window_inherited_functions": {
-            "assert": ["window functions are inherited"]
+          "window_exposed_functions": {
+            "assert": ["window functions are exposed"]
           },
           "window_functions": {
             "assert": ["window functions are instances of Function"]
@@ -35,12 +35,12 @@
              */
             test(
                 function(){
-                    assert_inherits(window, "matchMedia");
-                    assert_inherits(window, "scroll");
-                    assert_inherits(window, "scrollTo");
-                    assert_inherits(window, "scrollBy");
-                }, 'window_inherited_functions', {
-                  assert: ['window functions are inherited']
+                    assert_own_property(window, "matchMedia");
+                    assert_own_property(window, "scroll");
+                    assert_own_property(window, "scrollTo");
+                    assert_own_property(window, "scrollBy");
+                }, 'window_exposed_functions', {
+                  assert: ['window functions are exposed']
                 }
             );
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to