Title: [215866] trunk/Source/WebKit/mac
Revision
215866
Author
wenson_hs...@apple.com
Date
2017-04-27 08:31:33 -0700 (Thu, 27 Apr 2017)

Log Message

[WK1] Tweak the data interaction SPI to indicate whether or not a data interaction was handled
https://bugs.webkit.org/show_bug.cgi?id=171369
<rdar://problem/31858853>

Reviewed by Dan Bernstein.

Introduce a new SPI hook intended to replace performDataInteraction:client:global:operation: that
returns whether or not the data interaction was handled. Due to the difference only in return type
and some staging constraints, this version is prefixed with "_tryTo".

* WebView/WebView.mm:
(-[WebView _tryToPerformDataInteraction:client:global:operation:]):
* WebView/WebViewPrivate.h:

Modified Paths

Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (215865 => 215866)


--- trunk/Source/WebKit/mac/ChangeLog	2017-04-27 15:28:53 UTC (rev 215865)
+++ trunk/Source/WebKit/mac/ChangeLog	2017-04-27 15:31:33 UTC (rev 215866)
@@ -1,3 +1,19 @@
+2017-04-27  Wenson Hsieh  <wenson_hs...@apple.com>
+
+        [WK1] Tweak the data interaction SPI to indicate whether or not a data interaction was handled
+        https://bugs.webkit.org/show_bug.cgi?id=171369
+        <rdar://problem/31858853>
+
+        Reviewed by Dan Bernstein.
+
+        Introduce a new SPI hook intended to replace performDataInteraction:client:global:operation: that
+        returns whether or not the data interaction was handled. Due to the difference only in return type
+        and some staging constraints, this version is prefixed with "_tryTo".
+
+        * WebView/WebView.mm:
+        (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
+        * WebView/WebViewPrivate.h:
+
 2017-04-26  Wenson Hsieh  <wenson_hs...@apple.com>
 
         WebItemProviderPasteboard should not synchronously load provided data

Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (215865 => 215866)


--- trunk/Source/WebKit/mac/WebView/WebView.mm	2017-04-27 15:28:53 UTC (rev 215865)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm	2017-04-27 15:31:33 UTC (rev 215866)
@@ -1922,6 +1922,12 @@
 - (void)_performDataInteraction:(id)dataInteraction client:(CGPoint)clientPosition global:(CGPoint)globalPosition operation:(uint64_t)operation
 {
 }
+
+- (BOOL)_tryToPerformDataInteraction:(id)dataInteraction client:(CGPoint)clientPosition global:(CGPoint)globalPosition operation:(uint64_t)operation
+{
+    return NO;
+}
+
 - (void)_endedDataInteraction:(CGPoint)clientPosition global:(CGPoint)globalPosition
 {
 }

Modified: trunk/Source/WebKit/mac/WebView/WebViewPrivate.h (215865 => 215866)


--- trunk/Source/WebKit/mac/WebView/WebViewPrivate.h	2017-04-27 15:28:53 UTC (rev 215865)
+++ trunk/Source/WebKit/mac/WebView/WebViewPrivate.h	2017-04-27 15:31:33 UTC (rev 215866)
@@ -473,6 +473,7 @@
 - (uint64_t)_updatedDataInteraction:(id)dataInteraction client:(CGPoint)clientPosition global:(CGPoint)globalPosition operation:(uint64_t)operation;
 - (void)_exitedDataInteraction:(id)dataInteraction client:(CGPoint)clientPosition global:(CGPoint)globalPosition operation:(uint64_t)operation;
 - (void)_performDataInteraction:(id)dataInteraction client:(CGPoint)clientPosition global:(CGPoint)globalPosition operation:(uint64_t)operation;
+- (BOOL)_tryToPerformDataInteraction:(id)dataInteraction client:(CGPoint)clientPosition global:(CGPoint)globalPosition operation:(uint64_t)operation;
 - (void)_endedDataInteraction:(CGPoint)clientPosition global:(CGPoint)clientPosition;
 
 #if TARGET_OS_IPHONE
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to