Title: [216133] trunk/Source/WebCore
- Revision
- 216133
- Author
- jiewen_...@apple.com
- Date
- 2017-05-03 12:27:09 -0700 (Wed, 03 May 2017)
Log Message
ASSERTION FAILED: m_scriptExecutionContext->isContextThread() seen with LayoutTest crypto/workers/crypto-random-values-limits-worker.html
https://bugs.webkit.org/show_bug.cgi?id=171462
<rdar://problem/31906859>
Reviewed by Brent Fulgham.
Covered by existing tests.
* workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::~WorkerGlobalScope):
Clear Crypto early in destruction since its ContextDestructionObserver
destruction makes checks about the WorkerThread.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (216132 => 216133)
--- trunk/Source/WebCore/ChangeLog 2017-05-03 19:27:06 UTC (rev 216132)
+++ trunk/Source/WebCore/ChangeLog 2017-05-03 19:27:09 UTC (rev 216133)
@@ -1,3 +1,18 @@
+2017-05-03 Jiewen Tan <jiewen_...@apple.com>
+
+ ASSERTION FAILED: m_scriptExecutionContext->isContextThread() seen with LayoutTest crypto/workers/crypto-random-values-limits-worker.html
+ https://bugs.webkit.org/show_bug.cgi?id=171462
+ <rdar://problem/31906859>
+
+ Reviewed by Brent Fulgham.
+
+ Covered by existing tests.
+
+ * workers/WorkerGlobalScope.cpp:
+ (WebCore::WorkerGlobalScope::~WorkerGlobalScope):
+ Clear Crypto early in destruction since its ContextDestructionObserver
+ destruction makes checks about the WorkerThread.
+
2017-05-03 Zalan Bujtas <za...@apple.com>
RenderSearchField should not use isTextField() in SPECIALIZE_TYPE_TRAITS_RENDER_OBJECT
Modified: trunk/Source/WebCore/workers/WorkerGlobalScope.cpp (216132 => 216133)
--- trunk/Source/WebCore/workers/WorkerGlobalScope.cpp 2017-05-03 19:27:06 UTC (rev 216132)
+++ trunk/Source/WebCore/workers/WorkerGlobalScope.cpp 2017-05-03 19:27:09 UTC (rev 216133)
@@ -101,6 +101,8 @@
m_performance = nullptr;
#endif
+ m_crypto = nullptr;
+
// Notify proxy that we are going away. This can free the WorkerThread object, so do not access it after this.
thread().workerReportingProxy().workerGlobalScopeDestroyed();
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
