Title: [216210] trunk/Tools
- Revision
- 216210
- Author
- beid...@apple.com
- Date
- 2017-05-04 14:42:23 -0700 (Thu, 04 May 2017)
Log Message
[ios-simulator] API test WebKit2.WebsiteDataStoreCustomPaths is failing.
https://bugs.webkit.org/show_bug.cgi?id=171513
Unreviewed gardening.
* TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
(TEST): Skip the failing parts of the test on iOS for now.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (216209 => 216210)
--- trunk/Tools/ChangeLog 2017-05-04 21:39:44 UTC (rev 216209)
+++ trunk/Tools/ChangeLog 2017-05-04 21:42:23 UTC (rev 216210)
@@ -1,3 +1,13 @@
+2017-05-04 Brady Eidson <beid...@apple.com>
+
+ [ios-simulator] API test WebKit2.WebsiteDataStoreCustomPaths is failing.
+ https://bugs.webkit.org/show_bug.cgi?id=171513
+
+ Unreviewed gardening.
+
+ * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
+ (TEST): Skip the failing parts of the test on iOS for now.
+
2017-05-03 Jonathan Bedard <jbed...@apple.com>
Make ImageDiff stand-alone
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm (216209 => 216210)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm 2017-05-04 21:39:44 UTC (rev 216209)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm 2017-05-04 21:42:23 UTC (rev 216210)
@@ -125,6 +125,11 @@
EXPECT_TRUE([[NSFileManager defaultManager] fileExistsAtPath:idbPath.path]);
EXPECT_TRUE([[NSFileManager defaultManager] fileExistsAtPath:defaultIDBPath.path]);
+ // FIXME (https://bugs.webkit.org/show_bug.cgi?id=171513)
+ // Checking the following 3 files on iOS is too flakey when running tests in the iOS-sim.
+ // (For the cookie file, at least, it's because we can't sync it to disk)
+#if PLATFORM(MAC)
+
// FIXME: We currently don't have a reliable way to force sync on newer SDKs, so we can't test this on them.
#if (__MAC_OS_X_VERSION_MIN_REQUIRED < 101300)
[[[webView configuration] processPool] _syncNetworkProcessCookies];
@@ -139,10 +144,10 @@
auto result = [data rangeOfData:cookieKeyData.get() options:0 range:NSMakeRange(0, data.get().length)];
EXPECT_NE((const long)result.location, NSNotFound);
#endif
-
// FIXME: The default SQL and LocalStorage paths are being used for something, but they shouldn't be. (theses should be false, not true)
EXPECT_TRUE([[NSFileManager defaultManager] fileExistsAtPath:defaultSQLPath.path]);
EXPECT_TRUE([[NSFileManager defaultManager] fileExistsAtPath:defaultLocalStoragePath.path]);
+#endif
}
#endif
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
