Title: [216221] trunk/Source/WebCore
- Revision
- 216221
- Author
- commit-qu...@webkit.org
- Date
- 2017-05-04 17:57:51 -0700 (Thu, 04 May 2017)
Log Message
Use if instead of return early for 13 places in WebAVPlayerController
https://bugs.webkit.org/show_bug.cgi?id=171692
Patch by Jeremy Jones <jere...@apple.com> on 2017-05-04
Reviewed by Jer Noble.
No new tests because no behavior change.
* platform/ios/WebAVPlayerController.mm:
(-[WebAVPlayerController play:]):
(-[WebAVPlayerController pause:]):
(-[WebAVPlayerController togglePlayback:]):
(-[WebAVPlayerController beginScrubbing:]):
(-[WebAVPlayerController endScrubbing:]):
(-[WebAVPlayerController seekToTime:]):
(-[WebAVPlayerController beginScanningForward:]):
(-[WebAVPlayerController endScanningForward:]):
(-[WebAVPlayerController beginScanningBackward:]):
(-[WebAVPlayerController endScanningBackward:]):
(-[WebAVPlayerController seekToBeginning:]):
(-[WebAVPlayerController seekToEnd:]):
(-[WebAVPlayerController toggleMuted:]):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (216220 => 216221)
--- trunk/Source/WebCore/ChangeLog 2017-05-05 00:46:43 UTC (rev 216220)
+++ trunk/Source/WebCore/ChangeLog 2017-05-05 00:57:51 UTC (rev 216221)
@@ -1,3 +1,27 @@
+2017-05-04 Jeremy Jones <jere...@apple.com>
+
+ Use if instead of return early for 13 places in WebAVPlayerController
+ https://bugs.webkit.org/show_bug.cgi?id=171692
+
+ Reviewed by Jer Noble.
+
+ No new tests because no behavior change.
+
+ * platform/ios/WebAVPlayerController.mm:
+ (-[WebAVPlayerController play:]):
+ (-[WebAVPlayerController pause:]):
+ (-[WebAVPlayerController togglePlayback:]):
+ (-[WebAVPlayerController beginScrubbing:]):
+ (-[WebAVPlayerController endScrubbing:]):
+ (-[WebAVPlayerController seekToTime:]):
+ (-[WebAVPlayerController beginScanningForward:]):
+ (-[WebAVPlayerController endScanningForward:]):
+ (-[WebAVPlayerController beginScanningBackward:]):
+ (-[WebAVPlayerController endScanningBackward:]):
+ (-[WebAVPlayerController seekToBeginning:]):
+ (-[WebAVPlayerController seekToEnd:]):
+ (-[WebAVPlayerController toggleMuted:]):
+
2017-05-04 Filip Pizlo <fpi...@apple.com>
JSC::Heap should expose a richer API for requesting GCs
Modified: trunk/Source/WebCore/platform/ios/WebAVPlayerController.mm (216220 => 216221)
--- trunk/Source/WebCore/platform/ios/WebAVPlayerController.mm 2017-05-05 00:46:43 UTC (rev 216220)
+++ trunk/Source/WebCore/platform/ios/WebAVPlayerController.mm 2017-05-05 00:57:51 UTC (rev 216221)
@@ -88,25 +88,22 @@
- (void)play:(id)sender
{
UNUSED_PARAM(sender);
- if (!self.delegate)
- return;
- self.delegate->play();
+ if (self.delegate)
+ self.delegate->play();
}
- (void)pause:(id)sender
{
UNUSED_PARAM(sender);
- if (!self.delegate)
- return;
- self.delegate->pause();
+ if (self.delegate)
+ self.delegate->pause();
}
- (void)togglePlayback:(id)sender
{
UNUSED_PARAM(sender);
- if (!self.delegate)
- return;
- self.delegate->togglePlayState();
+ if (self.delegate)
+ self.delegate->togglePlayState();
}
- (void)togglePlaybackEvenWhenInBackground:(id)sender
@@ -137,24 +134,21 @@
- (void)beginScrubbing:(id)sender
{
UNUSED_PARAM(sender);
- if (!self.delegate)
- return;
- self.delegate->beginScrubbing();
+ if (self.delegate)
+ self.delegate->beginScrubbing();
}
- (void)endScrubbing:(id)sender
{
UNUSED_PARAM(sender);
- if (!self.delegate)
- return;
- self.delegate->endScrubbing();
+ if (self.delegate)
+ self.delegate->endScrubbing();
}
- (void)seekToTime:(NSTimeInterval)time
{
- if (!self.delegate)
- return;
- self.delegate->fastSeek(time);
+ if (self.delegate)
+ self.delegate->fastSeek(time);
}
- (NSTimeInterval)currentTimeWithinEndTimes
@@ -231,33 +225,29 @@
- (void)beginScanningForward:(id)sender
{
UNUSED_PARAM(sender);
- if (!self.delegate)
- return;
- self.delegate->beginScanningForward();
+ if (self.delegate)
+ self.delegate->beginScanningForward();
}
- (void)endScanningForward:(id)sender
{
UNUSED_PARAM(sender);
- if (!self.delegate)
- return;
- self.delegate->endScanning();
+ if (self.delegate)
+ self.delegate->endScanning();
}
- (void)beginScanningBackward:(id)sender
{
UNUSED_PARAM(sender);
- if (!self.delegate)
- return;
- self.delegate->beginScanningBackward();
+ if (self.delegate)
+ self.delegate->beginScanningBackward();
}
- (void)endScanningBackward:(id)sender
{
UNUSED_PARAM(sender);
- if (!self.delegate)
- return;
- self.delegate->endScanning();
+ if (self.delegate)
+ self.delegate->endScanning();
}
- (BOOL)canSeekToBeginning
@@ -278,9 +268,8 @@
- (void)seekToBeginning:(id)sender
{
UNUSED_PARAM(sender);
- if (!self.delegate)
- return;
- self.delegate->seekToTime(-INFINITY);
+ if (self.delegate)
+ self.delegate->seekToTime(-INFINITY);
}
- (void)seekChapterBackward:(id)sender
@@ -306,9 +295,8 @@
- (void)seekToEnd:(id)sender
{
UNUSED_PARAM(sender);
- if (!self.delegate)
- return;
- self.delegate->seekToTime(INFINITY);
+ if (self.delegate)
+ self.delegate->seekToTime(INFINITY);
}
- (void)seekChapterForward:(id)sender
@@ -428,9 +416,8 @@
- (void)toggleMuted:(id)sender
{
UNUSED_PARAM(sender);
- if (!self.delegate)
- return;
- self.delegate->toggleMuted();
+ if (self.delegate)
+ self.delegate->toggleMuted();
}
@end
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
