Title: [216231] trunk/Tools
- Revision
- 216231
- Author
- mark....@apple.com
- Date
- 2017-05-04 20:24:55 -0700 (Thu, 04 May 2017)
Log Message
API test WTF.StaticStringImpl crashing in TestWebKitAPI::WTF_StaticStringImpl_Test::TestBody() + 3188
https://bugs.webkit.org/show_bug.cgi?id=171702
Reviewed by Filip Pizlo.
The test was supposed to use the MAKE_STATIC_STRING_IMPL macro. I had previously
changed it to instantiate an automatic StaticStringImpl (i.e. stack allocated) to
confirm that the test will detect a regression. Unfortunately, I forgot to
change it back to using MAKE_STATIC_STRING_IMPL before I landed the test.
This patch fixes that.
* TestWebKitAPI/Tests/WTF/StringImpl.cpp:
(TestWebKitAPI::neverDestroyedString):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (216230 => 216231)
--- trunk/Tools/ChangeLog 2017-05-05 03:20:46 UTC (rev 216230)
+++ trunk/Tools/ChangeLog 2017-05-05 03:24:55 UTC (rev 216231)
@@ -1,3 +1,19 @@
+2017-05-04 Mark Lam <mark....@apple.com>
+
+ API test WTF.StaticStringImpl crashing in TestWebKitAPI::WTF_StaticStringImpl_Test::TestBody() + 3188
+ https://bugs.webkit.org/show_bug.cgi?id=171702
+
+ Reviewed by Filip Pizlo.
+
+ The test was supposed to use the MAKE_STATIC_STRING_IMPL macro. I had previously
+ changed it to instantiate an automatic StaticStringImpl (i.e. stack allocated) to
+ confirm that the test will detect a regression. Unfortunately, I forgot to
+ change it back to using MAKE_STATIC_STRING_IMPL before I landed the test.
+ This patch fixes that.
+
+ * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
+ (TestWebKitAPI::neverDestroyedString):
+
2017-05-04 Ryan Haddad <ryanhad...@apple.com>
Disable failing API test WebKit2.ResizeWithHiddenContentDoesNotHang.
Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/StringImpl.cpp (216230 => 216231)
--- trunk/Tools/TestWebKitAPI/Tests/WTF/StringImpl.cpp 2017-05-05 03:20:46 UTC (rev 216230)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/StringImpl.cpp 2017-05-05 03:24:55 UTC (rev 216231)
@@ -629,7 +629,7 @@
static const String& neverDestroyedString()
{
- static NeverDestroyed<String> str(StaticStringImpl("NeverDestroyedString"));
+ static NeverDestroyed<String> str(MAKE_STATIC_STRING_IMPL("NeverDestroyedString"));
return str;
};
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
