Title: [216879] trunk/Websites/webkit.org
- Revision
- 216879
- Author
- jcr...@apple.com
- Date
- 2017-05-15 14:36:32 -0700 (Mon, 15 May 2017)
Log Message
AX: Inaccessible content on webkit.org main page
https://bugs.webkit.org/show_bug.cgi?id=172106
Reviewed by Joseph Pecoraro.
* wp-content/themes/webkit/widgets/icon.php: Resolved link title.
* wp-content/themes/webkit/widgets/post.php: Resolved link title.
* wp-content/themes/webkit/widgets/twitter.php: Resolved link titles. Suppressed unlabeled images with alt="".
Modified Paths
Diff
Modified: trunk/Websites/webkit.org/ChangeLog (216878 => 216879)
--- trunk/Websites/webkit.org/ChangeLog 2017-05-15 21:23:23 UTC (rev 216878)
+++ trunk/Websites/webkit.org/ChangeLog 2017-05-15 21:36:32 UTC (rev 216879)
@@ -1,3 +1,14 @@
+2017-05-15 James Craig <jcr...@apple.com>
+
+ AX: Inaccessible content on webkit.org main page
+ https://bugs.webkit.org/show_bug.cgi?id=172106
+
+ Reviewed by Joseph Pecoraro.
+
+ * wp-content/themes/webkit/widgets/icon.php: Resolved link title.
+ * wp-content/themes/webkit/widgets/post.php: Resolved link title.
+ * wp-content/themes/webkit/widgets/twitter.php: Resolved link titles. Suppressed unlabeled images with alt="".
+
2017-05-14 James Craig <jcr...@apple.com>
Upload poster images and working captioned video
Modified: trunk/Websites/webkit.org/wp-content/themes/webkit/widgets/icon.php (216878 => 216879)
--- trunk/Websites/webkit.org/wp-content/themes/webkit/widgets/icon.php 2017-05-15 21:23:23 UTC (rev 216878)
+++ trunk/Websites/webkit.org/wp-content/themes/webkit/widgets/icon.php 2017-05-15 21:36:32 UTC (rev 216879)
@@ -30,7 +30,7 @@
?>
<div class="<?php echo esc_attr(join(' ', $classes)); ?>">
- <a class="tile-link" href="" echo esc_url($url); ?>">Clickable link</a>
+ <a class="tile-link" href="" echo esc_url($url); ?>"><?php echo nl2br(esc_html($text)); ?></a>
<div class="icon"></div>
<h2><?php echo nl2br(esc_html($text)); ?></h2>
<?php if (!empty($subtext)): ?><p><?php echo nl2br(esc_html($subtext)); ?></p><?php endif; ?>
Modified: trunk/Websites/webkit.org/wp-content/themes/webkit/widgets/post.php (216878 => 216879)
--- trunk/Websites/webkit.org/wp-content/themes/webkit/widgets/post.php 2017-05-15 21:23:23 UTC (rev 216878)
+++ trunk/Websites/webkit.org/wp-content/themes/webkit/widgets/post.php 2017-05-15 21:36:32 UTC (rev 216879)
@@ -59,7 +59,7 @@
?>
<div <?php echo post_class(join(' ', $classes)); ?>>
- <a class="tile-link" href="" the_permalink(); ?>">Clickable link</a>
+ <a class="tile-link" href="" the_permalink(); ?>"><?php echo $title; ?></a>
<div class="background-image">
<div class="featured-image"<?php echo $image; ?>></div>
<?php if ( $featured ): ?><div class="background-vignette"></div><?php endif; ?>
Modified: trunk/Websites/webkit.org/wp-content/themes/webkit/widgets/twitter.php (216878 => 216879)
--- trunk/Websites/webkit.org/wp-content/themes/webkit/widgets/twitter.php 2017-05-15 21:23:23 UTC (rev 216878)
+++ trunk/Websites/webkit.org/wp-content/themes/webkit/widgets/twitter.php 2017-05-15 21:36:32 UTC (rev 216879)
@@ -68,10 +68,10 @@
?>
<div class="<?php echo esc_attr(join(' ', $classes)); ?>">
- <a href="" echo esc_url($link); ?>" class="tile-link">Clickable link to tweet</a>
+ <a href="" echo esc_url($link); ?>" class="tile-link">Tweet: <?php echo $text; ?></a>
<div class="tile-content">
<?php if ( ! empty($Image) ): ?>
- <img src="" echo esc_url($Image->media_url_https); ?>">
+ <img src="" echo esc_url($Image->media_url_https); ?>" alt="">
<?php else: ?>
<?php endif;?>
<p><?php echo $text; ?></p>
@@ -94,7 +94,7 @@
?>
<div class="<?php echo esc_attr(join(' ', $classes)); ?>">
- <a class="tile-link" href="" echo esc_url($url); ?>">Clickable link</a>
+ <a class="tile-link" href="" echo esc_url($url); ?>"><?php echo nl2br(esc_html($options['text'])); ?></a>
<div class="icon twitter-icon"></div>
<h2><?php echo nl2br(esc_html($options['text'])); ?></h2>
</div>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
