Title: [218209] trunk/Source/WebCore
- Revision
- 218209
- Author
- jer.no...@apple.com
- Date
- 2017-06-13 15:07:50 -0700 (Tue, 13 Jun 2017)
Log Message
Crash when MSE backed media element changes src/srcObject during PiP
https://bugs.webkit.org/show_bug.cgi?id=173288
Reviewed by Alex Christensen.
Tear down the MediaPlayerPrivateMediaSourceAVFObjC's layers fully whe the player
is destroyed, which includes removing the player's AVSampleBufferDisplayLayer from
the HTMLMediaElement's fullscreen layer.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::~MediaPlayerPrivateMediaSourceAVFObjC):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (218208 => 218209)
--- trunk/Source/WebCore/ChangeLog 2017-06-13 22:06:58 UTC (rev 218208)
+++ trunk/Source/WebCore/ChangeLog 2017-06-13 22:07:50 UTC (rev 218209)
@@ -1,3 +1,17 @@
+2017-06-13 Jer Noble <jer.no...@apple.com>
+
+ Crash when MSE backed media element changes src/srcObject during PiP
+ https://bugs.webkit.org/show_bug.cgi?id=173288
+
+ Reviewed by Alex Christensen.
+
+ Tear down the MediaPlayerPrivateMediaSourceAVFObjC's layers fully whe the player
+ is destroyed, which includes removing the player's AVSampleBufferDisplayLayer from
+ the HTMLMediaElement's fullscreen layer.
+
+ * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
+ (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::~MediaPlayerPrivateMediaSourceAVFObjC):
+
2017-06-13 Daniel Bates <daba...@apple.com>
Implement W3C Secure Contexts Draft Specification
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm (218208 => 218209)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm 2017-06-13 22:06:58 UTC (rev 218208)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm 2017-06-13 22:07:50 UTC (rev 218209)
@@ -174,6 +174,9 @@
[m_synchronizer removeTimeObserver:m_durationObserver.get()];
flushPendingSizeChanges();
+ destroyLayer();
+ destroyDecompressionSession();
+
m_seekTimer.stop();
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
