Title: [218220] trunk/Source/_javascript_Core
- Revision
- 218220
- Author
- jfbast...@apple.com
- Date
- 2017-06-13 15:45:59 -0700 (Tue, 13 Jun 2017)
Log Message
WebAssembly: fix erroneous signature comment
https://bugs.webkit.org/show_bug.cgi?id=173334
Reviewed by Keith Miller.
* wasm/WasmSignature.h:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (218219 => 218220)
--- trunk/Source/_javascript_Core/ChangeLog 2017-06-13 22:44:06 UTC (rev 218219)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-06-13 22:45:59 UTC (rev 218220)
@@ -1,3 +1,12 @@
+2017-06-13 JF Bastien <jfbast...@apple.com>
+
+ WebAssembly: fix erroneous signature comment
+ https://bugs.webkit.org/show_bug.cgi?id=173334
+
+ Reviewed by Keith Miller.
+
+ * wasm/WasmSignature.h:
+
2017-06-13 Michael Saboff <msab...@apple.com>
Refactor AbsenceOfSetter to AbsenceOfSetEffects
Modified: trunk/Source/_javascript_Core/wasm/WasmSignature.h (218219 => 218220)
--- trunk/Source/_javascript_Core/wasm/WasmSignature.h 2017-06-13 22:44:06 UTC (rev 218219)
+++ trunk/Source/_javascript_Core/wasm/WasmSignature.h 2017-06-13 22:45:59 UTC (rev 218220)
@@ -156,8 +156,8 @@
namespace JSC { namespace Wasm {
-// Signature information is held globally on VM to allow all signatures to be unique. This is required when wasm calls another wasm instance.
-// Note: signatures are never removed from VM because that would require accounting for all WebAssembly.Module and which signatures they use. The maximum number of signatures is bounded, and isn't worth the counting overhead. We could clear everything when we reach zero outstanding WebAssembly.Module. https://bugs.webkit.org/show_bug.cgi?id=166037
+// Signature information is held globally and shared by VMs to allow all signatures to be unique. This is required when wasm calls another wasm instance, and must work when modules are shared between multiple VMs.
+// Note: signatures are never removed because that would require accounting for all WebAssembly.Module and which signatures they use. The maximum number of signatures is bounded, and isn't worth the counting overhead. We could clear everything when we reach zero outstanding WebAssembly.Module. https://bugs.webkit.org/show_bug.cgi?id=166037
class SignatureInformation {
WTF_MAKE_NONCOPYABLE(SignatureInformation);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
