Title: [218226] trunk
- Revision
- 218226
- Author
- cfleiz...@apple.com
- Date
- 2017-06-13 17:12:29 -0700 (Tue, 13 Jun 2017)
Log Message
AX[macOS]: Expose Inline property as an accessibility attribute
https://bugs.webkit.org/show_bug.cgi?id=173131
<rdar://problem/32667686>
Reviewed by Joanmarie Diggs.
Source/WebCore:
Expose whether a renderer is inline so that VoiceOver can make better use of that data when deciding what to output.
Test: accessibility/mac/inline-text-attribute.html
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
LayoutTests:
* accessibility/mac/inline-text-attribute.html: Added.
* accessibility/mac/inline-text-attribute-expected.txt: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (218225 => 218226)
--- trunk/LayoutTests/ChangeLog 2017-06-14 00:10:25 UTC (rev 218225)
+++ trunk/LayoutTests/ChangeLog 2017-06-14 00:12:29 UTC (rev 218226)
@@ -1,3 +1,14 @@
+2017-06-13 Chris Fleizach <cfleiz...@apple.com>
+
+ AX[macOS]: Expose Inline property as an accessibility attribute
+ https://bugs.webkit.org/show_bug.cgi?id=173131
+ <rdar://problem/32667686>
+
+ Reviewed by Joanmarie Diggs.
+
+ * accessibility/mac/inline-text-attribute.html: Added.
+ * accessibility/mac/inline-text-attribute-expected.txt: Added.
+
2017-06-13 Joseph Pecoraro <pecor...@apple.com>
Debugger has unexpected effect on program correctness
Added: trunk/LayoutTests/accessibility/mac/inline-text-attribute-expected.txt (0 => 218226)
--- trunk/LayoutTests/accessibility/mac/inline-text-attribute-expected.txt (rev 0)
+++ trunk/LayoutTests/accessibility/mac/inline-text-attribute-expected.txt 2017-06-14 00:12:29 UTC (rev 218226)
@@ -0,0 +1,14 @@
+a b c
+d
+e f
+This tests that objects return whether they are inline or not.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Span is inline: 1
+Div is inline: 0
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/accessibility/mac/inline-text-attribute.html (0 => 218226)
--- trunk/LayoutTests/accessibility/mac/inline-text-attribute.html (rev 0)
+++ trunk/LayoutTests/accessibility/mac/inline-text-attribute.html 2017-06-14 00:12:29 UTC (rev 218226)
@@ -0,0 +1,33 @@
+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<html>
+<head>
+<script src=""
+</head>
+<body id="body">
+
+a <span id="span" role="group"> b </span> c
+<br>
+
+d <div id="div" role="group"> e </span> f
+
+<p id="description"></p>
+<div id="console"></div>
+
+<script>
+
+ description("This tests that objects return whether they are inline or not.");
+
+ if (window.accessibilityController) {
+
+ var span = accessibilityController.accessibleElementById("span");
+ debug("Span is inline: " + span.numberAttributeValue('AXInlineText'));
+
+ var div = accessibilityController.accessibleElementById("div");
+ debug("Div is inline: " + div.numberAttributeValue('AXInlineText'));
+ }
+
+</script>
+
+<script src=""
+</body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (218225 => 218226)
--- trunk/Source/WebCore/ChangeLog 2017-06-14 00:10:25 UTC (rev 218225)
+++ trunk/Source/WebCore/ChangeLog 2017-06-14 00:12:29 UTC (rev 218226)
@@ -1,3 +1,18 @@
+2017-06-13 Chris Fleizach <cfleiz...@apple.com>
+
+ AX[macOS]: Expose Inline property as an accessibility attribute
+ https://bugs.webkit.org/show_bug.cgi?id=173131
+ <rdar://problem/32667686>
+
+ Reviewed by Joanmarie Diggs.
+
+ Expose whether a renderer is inline so that VoiceOver can make better use of that data when deciding what to output.
+
+ Test: accessibility/mac/inline-text-attribute.html
+
+ * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+ (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
+
2017-06-13 Jon Davis <j...@apple.com>
Update Subresource Integrity status to Supported In Preview
Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (218225 => 218226)
--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2017-06-14 00:10:25 UTC (rev 218225)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2017-06-14 00:12:29 UTC (rev 218226)
@@ -65,6 +65,7 @@
#import "Page.h"
#import "PluginDocument.h"
#import "PluginViewBase.h"
+#import "RenderInline.h"
#import "RenderTextControl.h"
#import "RenderView.h"
#import "RenderWidget.h"
@@ -192,6 +193,10 @@
#define NSAccessibilityDatetimeValueAttribute @"AXDateTimeValue"
#endif
+#ifndef NSAccessibilityInlineTextAttribute
+#define NSAccessibilityInlineTextAttribute @"AXInlineText"
+#endif
+
#ifndef NSAccessibilityDropEffectsAttribute
#define NSAccessibilityDropEffectsAttribute @"AXDropEffects"
#endif
@@ -3056,7 +3061,10 @@
if ([attributeName isEqualToString:NSAccessibilityDatetimeValueAttribute])
return m_object->datetimeAttributeValue();
-
+
+ if ([attributeName isEqualToString:NSAccessibilityInlineTextAttribute])
+ return @(m_object->renderer() && is<RenderInline>(m_object->renderer()));
+
// ARIA Live region attributes.
if ([attributeName isEqualToString:NSAccessibilityARIALiveAttribute])
return m_object->ariaLiveRegionStatus();
@@ -4269,3 +4277,4 @@
@end
#endif // HAVE(ACCESSIBILITY)
+
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
