Title: [219058] trunk/Source/WebCore
- Revision
- 219058
- Author
- commit-qu...@webkit.org
- Date
- 2017-07-02 11:43:23 -0700 (Sun, 02 Jul 2017)
Log Message
RealtimeOutgoingVideoSource should pass frame timestamp
https://bugs.webkit.org/show_bug.cgi?id=174055
Patch by Youenn Fablet <you...@apple.com> on 2017-07-02
Reviewed by Eric Carlson.
Covered by manual testing since this only affects video encoding quality.
* platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp:
(WebCore::RealtimeOutgoingVideoSource::sendFrame):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (219057 => 219058)
--- trunk/Source/WebCore/ChangeLog 2017-07-02 06:48:02 UTC (rev 219057)
+++ trunk/Source/WebCore/ChangeLog 2017-07-02 18:43:23 UTC (rev 219058)
@@ -1,3 +1,15 @@
+2017-07-02 Youenn Fablet <you...@apple.com>
+
+ RealtimeOutgoingVideoSource should pass frame timestamp
+ https://bugs.webkit.org/show_bug.cgi?id=174055
+
+ Reviewed by Eric Carlson.
+
+ Covered by manual testing since this only affects video encoding quality.
+
+ * platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp:
+ (WebCore::RealtimeOutgoingVideoSource::sendFrame):
+
2017-07-01 Dan Bernstein <m...@apple.com>
<rdar://problem/33096441> r219055 broke non-iOS builds.
Modified: trunk/Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp (219057 => 219058)
--- trunk/Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp 2017-07-02 06:48:02 UTC (rev 219057)
+++ trunk/Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp 2017-07-02 18:43:23 UTC (rev 219058)
@@ -35,6 +35,7 @@
#include <webrtc/api/video/i420_buffer.h>
#include <webrtc/common_video/libyuv/include/webrtc_libyuv.h>
#include <webrtc/sdk/objc/Framework/Classes/Video/corevideo_frame_buffer.h>
+#include <wtf/CurrentTime.h>
#include <wtf/MainThread.h>
#include "CoreMediaSoftLink.h"
@@ -185,7 +186,8 @@
void RealtimeOutgoingVideoSource::sendFrame(rtc::scoped_refptr<webrtc::VideoFrameBuffer>&& buffer)
{
- webrtc::VideoFrame frame(buffer, 0, 0, m_shouldApplyRotation ? webrtc::kVideoRotation_0 : m_currentRotation);
+ int64_t timestampMicroSeconds = monotonicallyIncreasingTimeMS() * 1000;
+ webrtc::VideoFrame frame(buffer, m_shouldApplyRotation ? webrtc::kVideoRotation_0 : m_currentRotation, timestampMicroSeconds);
for (auto* sink : m_sinks)
sink->OnFrame(frame);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
