Title: [219173] trunk
- Revision
- 219173
- Author
- mmaxfi...@apple.com
- Date
- 2017-07-05 17:26:31 -0700 (Wed, 05 Jul 2017)
Log Message
CSSFontStyleValue::isItalic seems a bit bogus.
https://bugs.webkit.org/show_bug.cgi?id=174149
Reviewed by Tim Horton.
Source/WebCore:
Simple typo.
Test: editing/execCommand/italicizeByCharacter-normal.html
* css/CSSFontStyleValue.h:
LayoutTests:
* editing/execCommand/italicizeByCharacter-normal-expected.txt: Added.
* editing/execCommand/italicizeByCharacter-normal.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (219172 => 219173)
--- trunk/LayoutTests/ChangeLog 2017-07-06 00:05:36 UTC (rev 219172)
+++ trunk/LayoutTests/ChangeLog 2017-07-06 00:26:31 UTC (rev 219173)
@@ -1,3 +1,13 @@
+2017-07-05 Myles C. Maxfield <mmaxfi...@apple.com>
+
+ CSSFontStyleValue::isItalic seems a bit bogus.
+ https://bugs.webkit.org/show_bug.cgi?id=174149
+
+ Reviewed by Tim Horton.
+
+ * editing/execCommand/italicizeByCharacter-normal-expected.txt: Added.
+ * editing/execCommand/italicizeByCharacter-normal.html: Added.
+
2017-07-05 Matt Lewis <jlew...@apple.com>
Skipped webgl/1.0.2/conformance/glsl/misc/shader-with-non-reserved-words.html.
Added: trunk/LayoutTests/editing/execCommand/italicizeByCharacter-normal-expected.txt (0 => 219173)
--- trunk/LayoutTests/editing/execCommand/italicizeByCharacter-normal-expected.txt (rev 0)
+++ trunk/LayoutTests/editing/execCommand/italicizeByCharacter-normal-expected.txt 2017-07-06 00:26:31 UTC (rev 219173)
@@ -0,0 +1,4 @@
+This tests italicizing the first character. The double quotation at the beginning must be italicized.
+
+"The quick brown fox jumps over the lazy dog" uses every letter in the english language.
+execItalicCommand: <span id="test"><i>"</i></span><span style="font-style: normal;">The quick brown fox jumps over the lazy dog" uses every letter in the english language. </span>
Added: trunk/LayoutTests/editing/execCommand/italicizeByCharacter-normal.html (0 => 219173)
--- trunk/LayoutTests/editing/execCommand/italicizeByCharacter-normal.html (rev 0)
+++ trunk/LayoutTests/editing/execCommand/italicizeByCharacter-normal.html 2017-07-06 00:26:31 UTC (rev 219173)
@@ -0,0 +1,38 @@
+<html>
+<head>
+
+<style>
+.editing {
+ border: 2px solid red;
+ padding: 12px;
+ font-size: 24px;
+}
+</style>
+<script src="" language="_javascript_" type="text/_javascript_" ></script>
+
+<script>
+
+function editingTest() {
+ execExtendSelectionForwardByCharacterCommand();
+ italicCommand();
+}
+
+</script>
+
+<title>Editing Test</title>
+</head>
+<body>
+<p>This tests italicizing the first character. The double quotation at the beginning must be italicized.</p>
+<div contenteditable id="root" class="editing">
+<span id="test" style="font-style: normal;">"The quick brown fox jumps over the lazy dog" uses every
+letter in the english language.
+</span>
+</div>
+
+<script>
+runDumpAsTextEditingTest();
+</script>
+
+</body>
+</html>
+
Modified: trunk/Source/WebCore/ChangeLog (219172 => 219173)
--- trunk/Source/WebCore/ChangeLog 2017-07-06 00:05:36 UTC (rev 219172)
+++ trunk/Source/WebCore/ChangeLog 2017-07-06 00:26:31 UTC (rev 219173)
@@ -1,3 +1,16 @@
+2017-07-05 Myles C. Maxfield <mmaxfi...@apple.com>
+
+ CSSFontStyleValue::isItalic seems a bit bogus.
+ https://bugs.webkit.org/show_bug.cgi?id=174149
+
+ Reviewed by Tim Horton.
+
+ Simple typo.
+
+ Test: editing/execCommand/italicizeByCharacter-normal.html
+
+ * css/CSSFontStyleValue.h:
+
2017-07-05 Brady Eidson <beid...@apple.com>
Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
Modified: trunk/Source/WebCore/css/CSSFontStyleValue.h (219172 => 219173)
--- trunk/Source/WebCore/css/CSSFontStyleValue.h 2017-07-06 00:05:36 UTC (rev 219172)
+++ trunk/Source/WebCore/css/CSSFontStyleValue.h 2017-07-06 00:26:31 UTC (rev 219173)
@@ -50,7 +50,7 @@
{
if (!obliqueValue) {
auto valueID = fontStyleValue->valueID();
- return valueID == CSSValueItalic || CSSValueOblique;
+ return valueID == CSSValueItalic || valueID == CSSValueOblique;
}
return obliqueValue->value<float>(CSSPrimitiveValue::CSS_DEG) >= static_cast<float>(italicValue());
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
