Log Message
Tools: Bring mac expectations in-line with other platforms https://bugs.webkit.org/show_bug.cgi?id=174472 <rdar://problem/33297388>
Reviewed by David Kilzer.
The override order for Mac test expectations does not conform to the pattern used by iOS,
GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
platform/mac-wk2
platform/wk2
platform/mac-elcapitan
platform/mac-sierra
generic
After this change, El Capitan's baseline search path looks like this:
platform/mac-sierra-wk2
platform/mac-sierra
platform/mac-wk2
platform/wk2
generic
* Scripts/webkitpy/port/mac.py:
(MacPort.__init__): If a specific version is specified in the port name, use that
as the os version.
(MacPort.default_baseline_search_path): Expectation search paths should work the
same way they do on other ports. Port + version overrides port, port overrides generic
and wk1/wk2 should override expectations for the two combined.
* Scripts/webkitpy/port/mac_unittest.py:
(MacTest.test_tests_for_other_platforms): Deleted.
(MacTest._assert_search_path): Deleted.
(MacTest.test_baseline_search_path): Deleted.
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
(test_rebaseline_test_and_print_scm_changes): Ditto.
(test_rebaseline_and_copy_test): Ditto.
(test_rebaseline_and_copy_test_no_existing_result): Ditto.
(test_rebaseline_and_copy_test_with_lion_result): Ditto.
(test_rebaseline_and_copy_no_overwrite_test): Ditto.
LayoutTests:
Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
https://bugs.webkit.org/show_bug.cgi?id=174438
<rdar://problem/33277112>
Reviewed by David Kilzer.
* platform/mac-wk2/TestExpectations: Move skipped tests because of webkit.org/b/174504.
* platform/wk2/TestExpectations: Ditto.
Modified Paths
- trunk/LayoutTests/ChangeLog
- trunk/LayoutTests/platform/mac-wk2/TestExpectations
- trunk/LayoutTests/platform/wk2/TestExpectations
- trunk/Tools/ChangeLog
- trunk/Tools/Scripts/webkitpy/port/mac.py
- trunk/Tools/Scripts/webkitpy/port/mac_unittest.py
- trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py
Diff
Modified: trunk/LayoutTests/ChangeLog (219506 => 219507)
--- trunk/LayoutTests/ChangeLog 2017-07-14 16:03:47 UTC (rev 219506)
+++ trunk/LayoutTests/ChangeLog 2017-07-14 17:15:02 UTC (rev 219507)
@@ -1,3 +1,14 @@
+2017-07-14 Jonathan Bedard <jbed...@apple.com>
+
+ Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
+ https://bugs.webkit.org/show_bug.cgi?id=174438
+ <rdar://problem/33277112>
+
+ Reviewed by David Kilzer.
+
+ * platform/mac-wk2/TestExpectations: Move skipped tests because of webkit.org/b/174504.
+ * platform/wk2/TestExpectations: Ditto.
+
2017-07-14 Fujii Hironori <hironori.fu...@sony.com>
[HarfBuzz] Decomposed Vietnamese characters are rendered incorrectly
Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (219506 => 219507)
--- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2017-07-14 16:03:47 UTC (rev 219506)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2017-07-14 17:15:02 UTC (rev 219507)
@@ -408,6 +408,37 @@
########################################
### START OF (4) Features that are not supported in WebKit2 and likely never will be
+# WebKitTestRunner needs textInputController
+# <https://bugs.webkit.org/show_bug.cgi?id=42337>
+editing/mac/input/5576619.html
+editing/mac/input/bold-node.html
+editing/mac/input/caret-primary-bidi.html
+editing/mac/input/firstrectforcharacterrange-caret-in-br.html
+editing/mac/input/firstrectforcharacterrange-plain.html
+editing/mac/input/firstrectforcharacterrange-styled.html
+editing/mac/input/firstrectforcharacterrange-vertical.html
+editing/mac/input/hangul-enter-confirms-and-sends-keypress.html
+editing/mac/input/insert-delete-smp-symbol.html
+editing/mac/input/kotoeri-enter-to-confirm-and-newline.html
+editing/mac/input/range-for-empty-document.html
+editing/mac/input/replace-invalid-range.html
+editing/mac/input/secure-input.html
+editing/mac/input/text-input-controller.html
+editing/mac/input/text-input-controller-no-editable-no-crash.html
+editing/mac/input/wrapped-line-char-rect.html
+editing/mac/input/NSBackgroundColor-transparent.html
+editing/mac/pasteboard/paste-and-match-style-selector-event.html
+editing/mac/selection/25228.html
+
+# WebKitTestRunner needs testRunner.setCallCloseOnWebViews
+# http://webkit.org/b/46714
+accessibility/mac/search-predicate.html
+
+# AX tests that require hit testing do not work in WK2.
+webkit.org/b/71298 accessibility/mac/html-slider-indicator.html
+webkit.org/b/71298 accessibility/mac/listbox-hit-test.html
+webkit.org/b/71298 accessibility/mac/iframe-with-title-correct-hierarchy.html
+
### END OF (4) Features that are not supported in WebKit2 and likely never will be
########################################
Modified: trunk/LayoutTests/platform/wk2/TestExpectations (219506 => 219507)
--- trunk/LayoutTests/platform/wk2/TestExpectations 2017-07-14 16:03:47 UTC (rev 219506)
+++ trunk/LayoutTests/platform/wk2/TestExpectations 2017-07-14 17:15:02 UTC (rev 219507)
@@ -47,9 +47,6 @@
# AX tests that require hit testing do not work in WK2.
webkit.org/b/71298 accessibility/loading-iframe-updates-axtree.html
-webkit.org/b/71298 accessibility/mac/html-slider-indicator.html
-webkit.org/b/71298 accessibility/mac/listbox-hit-test.html
-webkit.org/b/71298 accessibility/mac/iframe-with-title-correct-hierarchy.html
# This test has been skipped for a long time. Temporarily marking as flaky to see what bots think.
webkit.org/b/48354 compositing/iframes/iframe-src-change.html [ Pass Failure ]
@@ -84,25 +81,6 @@
fast/events/ime-composition-events-001.html
fast/forms/cursor-at-editable-content-boundary.html
fast/text/international/thai-cursor-position.html
-editing/mac/input/5576619.html
-editing/mac/input/bold-node.html
-editing/mac/input/caret-primary-bidi.html
-editing/mac/input/firstrectforcharacterrange-caret-in-br.html
-editing/mac/input/firstrectforcharacterrange-plain.html
-editing/mac/input/firstrectforcharacterrange-styled.html
-editing/mac/input/firstrectforcharacterrange-vertical.html
-editing/mac/input/hangul-enter-confirms-and-sends-keypress.html
-editing/mac/input/insert-delete-smp-symbol.html
-editing/mac/input/kotoeri-enter-to-confirm-and-newline.html
-editing/mac/input/range-for-empty-document.html
-editing/mac/input/replace-invalid-range.html
-editing/mac/input/secure-input.html
-editing/mac/input/text-input-controller.html
-editing/mac/input/text-input-controller-no-editable-no-crash.html
-editing/mac/input/wrapped-line-char-rect.html
-editing/mac/input/NSBackgroundColor-transparent.html
-editing/mac/pasteboard/paste-and-match-style-selector-event.html
-editing/mac/selection/25228.html
platform/mac/fast/dom/character-index-for-point.html
platform/mac/fast/text/attributed-substring-from-range-001.html
platform/mac/fast/text/attributed-substring-from-range-002.html
@@ -152,8 +130,6 @@
plugins/geturlnotify-during-document-teardown.html
plugins/open-and-close-window-with-plugin.html
-accessibility/mac/search-predicate.html
-
# Sometimes fails
# http://webkit.org/b/58990
editing/undo/undo-iframe-location-change.html
Modified: trunk/Tools/ChangeLog (219506 => 219507)
--- trunk/Tools/ChangeLog 2017-07-14 16:03:47 UTC (rev 219506)
+++ trunk/Tools/ChangeLog 2017-07-14 17:15:02 UTC (rev 219507)
@@ -1,3 +1,46 @@
+2017-07-14 Jonathan Bedard <jbed...@apple.com>
+
+ Bring mac expectations in-line with other platforms
+ https://bugs.webkit.org/show_bug.cgi?id=174472
+ <rdar://problem/33297388>
+
+ Reviewed by David Kilzer.
+
+ The override order for Mac test expectations does not conform to the pattern used by iOS,
+ GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
+
+ platform/mac-wk2
+ platform/wk2
+ platform/mac-elcapitan
+ platform/mac-sierra
+ generic
+
+ After this change, El Capitan's baseline search path looks like this:
+
+ platform/mac-sierra-wk2
+ platform/mac-sierra
+ platform/mac-wk2
+ platform/wk2
+ generic
+
+ * Scripts/webkitpy/port/mac.py:
+ (MacPort.__init__): If a specific version is specified in the port name, use that
+ as the os version.
+ (MacPort.default_baseline_search_path): Expectation search paths should work the
+ same way they do on other ports. Port + version overrides port, port overrides generic
+ and wk1/wk2 should override expectations for the two combined.
+ * Scripts/webkitpy/port/mac_unittest.py:
+ (MacTest.test_tests_for_other_platforms): Deleted.
+ (MacTest._assert_search_path): Deleted.
+ (MacTest.test_baseline_search_path): Deleted.
+ * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
+ (TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
+ (test_rebaseline_test_and_print_scm_changes): Ditto.
+ (test_rebaseline_and_copy_test): Ditto.
+ (test_rebaseline_and_copy_test_no_existing_result): Ditto.
+ (test_rebaseline_and_copy_test_with_lion_result): Ditto.
+ (test_rebaseline_and_copy_no_overwrite_test): Ditto.
+
2017-07-13 Michael Catanzaro <mcatanz...@igalia.com>
Fix style checker unit test
Modified: trunk/Tools/Scripts/webkitpy/port/mac.py (219506 => 219507)
--- trunk/Tools/Scripts/webkitpy/port/mac.py 2017-07-14 16:03:47 UTC (rev 219506)
+++ trunk/Tools/Scripts/webkitpy/port/mac.py 2017-07-14 17:15:02 UTC (rev 219507)
@@ -32,6 +32,7 @@
import time
import re
+from webkitpy.common.memoized import memoized
from webkitpy.common.system.executive import ScriptError
from webkitpy.port.darwin import DarwinPort
@@ -50,20 +51,25 @@
def __init__(self, host, port_name, **kwargs):
DarwinPort.__init__(self, host, port_name, **kwargs)
+ self._os_version = port_name.split('-')[1] if port_name.split('-') > 1 else self.host.platform.os_version
def _build_driver_flags(self):
return ['ARCHS=i386'] if self.architecture() == 'x86' else []
+ @memoized
def default_baseline_search_path(self):
- name = self._name.replace('-wk2', '')
- wk_version = [] if self.get_option('webkit_test_runner') else ['mac-wk1']
- if name.endswith(self.FUTURE_VERSION):
- fallback_names = wk_version + [self.port_name]
- else:
- fallback_names = self.VERSION_FALLBACK_ORDER[self.VERSION_FALLBACK_ORDER.index(name):-1] + wk_version + [self.port_name]
- # FIXME: mac-wk2 should appear at the same place as mac-wk1.
+ wk_string = 'wk1'
if self.get_option('webkit_test_runner'):
- fallback_names = [self._wk2_port_name(), 'wk2'] + fallback_names
+ wk_string = 'wk2'
+ fallback_names = [
+ '{}-{}-{}'.format(self.port_name, self._os_version, wk_string),
+ '{}-{}'.format(self.port_name, self._os_version),
+ '{}-{}'.format(self.port_name, wk_string),
+ self.port_name,
+ ]
+ if self.get_option('webkit_test_runner'):
+ fallback_names.append('wk2')
+
return map(self._webkit_baseline_path, fallback_names)
def configuration_specifier_macros(self):
Modified: trunk/Tools/Scripts/webkitpy/port/mac_unittest.py (219506 => 219507)
--- trunk/Tools/Scripts/webkitpy/port/mac_unittest.py 2017-07-14 16:03:47 UTC (rev 219506)
+++ trunk/Tools/Scripts/webkitpy/port/mac_unittest.py 2017-07-14 17:15:02 UTC (rev 219507)
@@ -44,17 +44,6 @@
port_name = 'mac-lion'
port_maker = MacPort
- def test_tests_for_other_platforms(self):
- platforms = ['mac', 'mac-snowleopard']
- port = self.make_port(port_name='mac-snowleopard')
- platform_dir_paths = map(port._webkit_baseline_path, platforms)
- # Replace our empty mock file system with one which has our expected platform directories.
- port._filesystem = MockFileSystem(dirs=platform_dir_paths)
-
- dirs_to_skip = port._tests_for_other_platforms()
- self.assertNotIn('platform/mac', dirs_to_skip)
- self.assertNotIn('platform/mac-snowleopard', dirs_to_skip)
-
def test_version(self):
port = self.make_port()
self.assertTrue(port.version())
@@ -92,33 +81,6 @@
self.assertEqual(env['MallocScribble'], '1')
self.assertEqual(env['DYLD_INSERT_LIBRARIES'], '/usr/lib/libgmalloc.dylib:/mock-build/libWebCoreTestShim.dylib')
- def _assert_search_path(self, port_name, baseline_path, search_paths, use_webkit2=False):
- port = self.make_port(port_name=port_name, options=MockOptions(webkit_test_runner=use_webkit2))
- absolute_search_paths = map(port._webkit_baseline_path, search_paths)
- self.assertEqual(port.baseline_path(), port._webkit_baseline_path(baseline_path))
- self.assertEqual(port.baseline_search_path(), absolute_search_paths)
-
- def test_baseline_search_path(self):
- # Note that we don't need total coverage here, just path coverage, since this is all data driven.
- self._assert_search_path('mac-snowleopard', 'mac-snowleopard', ['mac-snowleopard', 'mac-lion', 'mac-mountainlion', 'mac-mavericks', 'mac-yosemite', 'mac-elcapitan', 'mac-sierra', 'mac-wk1', 'mac'])
- self._assert_search_path('mac-lion', 'mac-lion', ['mac-lion', 'mac-mountainlion', 'mac-mavericks', 'mac-yosemite', 'mac-elcapitan', 'mac-sierra', 'mac-wk1', 'mac'])
- self._assert_search_path('mac-mountainlion', 'mac-mountainlion', ['mac-mountainlion', 'mac-mavericks', 'mac-yosemite', 'mac-elcapitan', 'mac-sierra', 'mac-wk1', 'mac'])
- self._assert_search_path('mac-mavericks', 'mac-mavericks', ['mac-mavericks', 'mac-yosemite', 'mac-elcapitan', 'mac-sierra', 'mac-wk1', 'mac'])
- self._assert_search_path('mac-yosemite', 'mac-yosemite', ['mac-yosemite', 'mac-elcapitan', 'mac-sierra', 'mac-wk1', 'mac'])
- self._assert_search_path('mac-elcapitan', 'mac-elcapitan', ['mac-elcapitan', 'mac-sierra', 'mac-wk1', 'mac'])
- self._assert_search_path('mac-sierra', 'mac-sierra', ['mac-sierra', 'mac-wk1', 'mac'])
- self._assert_search_path('mac-highsierra', 'mac-wk1', ['mac-wk1', 'mac'])
- self._assert_search_path('mac-future', 'mac-wk1', ['mac-wk1', 'mac'])
- self._assert_search_path('mac-snowleopard', 'mac-wk2', ['mac-wk2', 'wk2', 'mac-snowleopard', 'mac-lion', 'mac-mountainlion', 'mac-mavericks', 'mac-yosemite', 'mac-elcapitan', 'mac-sierra', 'mac'], use_webkit2=True)
- self._assert_search_path('mac-lion', 'mac-wk2', ['mac-wk2', 'wk2', 'mac-lion', 'mac-mountainlion', 'mac-mavericks', 'mac-yosemite', 'mac-elcapitan', 'mac-sierra', 'mac'], use_webkit2=True)
- self._assert_search_path('mac-mountainlion', 'mac-wk2', ['mac-wk2', 'wk2', 'mac-mountainlion', 'mac-mavericks', 'mac-yosemite', 'mac-elcapitan', 'mac-sierra', 'mac'], use_webkit2=True)
- self._assert_search_path('mac-mavericks', 'mac-wk2', ['mac-wk2', 'wk2', 'mac-mavericks', 'mac-yosemite', 'mac-elcapitan', 'mac-sierra', 'mac'], use_webkit2=True)
- self._assert_search_path('mac-yosemite', 'mac-wk2', ['mac-wk2', 'wk2', 'mac-yosemite', 'mac-elcapitan', 'mac-sierra', 'mac'], use_webkit2=True)
- self._assert_search_path('mac-elcapitan', 'mac-wk2', ['mac-wk2', 'wk2', 'mac-elcapitan', 'mac-sierra', 'mac'], use_webkit2=True)
- self._assert_search_path('mac-sierra', 'mac-wk2', ['mac-wk2', 'wk2', 'mac-sierra', 'mac'], use_webkit2=True)
- self._assert_search_path('mac-highsierra', 'mac-wk2', ['mac-wk2', 'wk2', 'mac'], use_webkit2=True)
- self._assert_search_path('mac-future', 'mac-wk2', ['mac-wk2', 'wk2', 'mac'], use_webkit2=True)
-
def test_show_results_html_file(self):
port = self.make_port()
# Delay setting a should_log executive to avoid logging from MacPort.__init__.
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py (219506 => 219507)
--- trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py 2017-07-14 16:03:47 UTC (rev 219506)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py 2017-07-14 17:15:02 UTC (rev 219507)
@@ -85,14 +85,14 @@
command = self.command
self.assertMultiLineEqual(command._baseline_directory("Apple Win XP Debug (Tests)"), "/mock-checkout/LayoutTests/platform/win-xp")
self.assertMultiLineEqual(command._baseline_directory("Apple Win 7 Release (Tests)"), "/mock-checkout/LayoutTests/platform/win")
- self.assertMultiLineEqual(command._baseline_directory("Apple Lion Release WK1 (Tests)"), "/mock-checkout/LayoutTests/platform/mac-lion")
- self.assertMultiLineEqual(command._baseline_directory("Apple Lion Release WK2 (Tests)"), "/mock-checkout/LayoutTests/platform/mac-wk2")
- self.assertMultiLineEqual(command._baseline_directory("Apple MountainLion Release WK1 (Tests)"), "/mock-checkout/LayoutTests/platform/mac-mountainlion")
- self.assertMultiLineEqual(command._baseline_directory("Apple MountainLion Release WK2 (Tests)"), "/mock-checkout/LayoutTests/platform/mac-wk2")
- self.assertMultiLineEqual(command._baseline_directory("Apple Mavericks Release WK1 (Tests)"), "/mock-checkout/LayoutTests/platform/mac-mavericks")
- self.assertMultiLineEqual(command._baseline_directory("Apple Mavericks Release WK2 (Tests)"), "/mock-checkout/LayoutTests/platform/mac-wk2")
- self.assertMultiLineEqual(command._baseline_directory("Apple Yosemite Release WK1 (Tests)"), "/mock-checkout/LayoutTests/platform/mac-yosemite")
- self.assertMultiLineEqual(command._baseline_directory("Apple Yosemite Release WK2 (Tests)"), "/mock-checkout/LayoutTests/platform/mac-wk2")
+ self.assertMultiLineEqual(command._baseline_directory("Apple Lion Release WK1 (Tests)"), "/mock-checkout/LayoutTests/platform/mac-lion-wk1")
+ self.assertMultiLineEqual(command._baseline_directory("Apple Lion Release WK2 (Tests)"), "/mock-checkout/LayoutTests/platform/mac-lion-wk2")
+ self.assertMultiLineEqual(command._baseline_directory("Apple MountainLion Release WK1 (Tests)"), "/mock-checkout/LayoutTests/platform/mac-mountainlion-wk1")
+ self.assertMultiLineEqual(command._baseline_directory("Apple MountainLion Release WK2 (Tests)"), "/mock-checkout/LayoutTests/platform/mac-mountainlion-wk2")
+ self.assertMultiLineEqual(command._baseline_directory("Apple Mavericks Release WK1 (Tests)"), "/mock-checkout/LayoutTests/platform/mac-mavericks-wk1")
+ self.assertMultiLineEqual(command._baseline_directory("Apple Mavericks Release WK2 (Tests)"), "/mock-checkout/LayoutTests/platform/mac-mavericks-wk2")
+ self.assertMultiLineEqual(command._baseline_directory("Apple Yosemite Release WK1 (Tests)"), "/mock-checkout/LayoutTests/platform/mac-yosemite-wk1")
+ self.assertMultiLineEqual(command._baseline_directory("Apple Yosemite Release WK2 (Tests)"), "/mock-checkout/LayoutTests/platform/mac-yosemite-wk2")
self.assertMultiLineEqual(command._baseline_directory("GTK Linux 64-bit Debug (Tests)"), "/mock-checkout/LayoutTests/platform/gtk")
self.assertMultiLineEqual(command._baseline_directory("GTK Linux 64-bit Release (Tests)"), "/mock-checkout/LayoutTests/platform/gtk")
@@ -163,7 +163,7 @@
self.command._rebaseline_test("Apple Lion Release WK1 (Tests)", "userscripts/another-test.html", None, "txt", None)
- self.assertDictEqual(self.command._scm_changes, {'add': ['/mock-checkout/LayoutTests/platform/mac-lion/userscripts/another-test-expected.txt'], 'delete': []})
+ self.assertDictEqual(self.command._scm_changes, {'add': ['/mock-checkout/LayoutTests/platform/mac-lion-wk1/userscripts/another-test-expected.txt'], 'delete': []})
def test_rebaseline_and_copy_test(self):
self._write("userscripts/another-test-expected.txt", "generic result")
@@ -170,13 +170,13 @@
self.command._rebaseline_test("Apple Lion Release WK1 (Tests)", "userscripts/another-test.html", ["mac-lion-wk2"], "txt", None)
- self.assertMultiLineEqual(self._read('platform/mac-lion/userscripts/another-test-expected.txt'), self.MOCK_WEB_RESULT)
- self.assertMultiLineEqual(self._read('platform/mac-wk2/userscripts/another-test-expected.txt'), 'generic result')
+ self.assertMultiLineEqual(self._read('platform/mac-lion-wk1/userscripts/another-test-expected.txt'), self.MOCK_WEB_RESULT)
+ self.assertMultiLineEqual(self._read('platform/mac-lion-wk2/userscripts/another-test-expected.txt'), 'generic result')
def test_rebaseline_and_copy_test_no_existing_result(self):
self.command._rebaseline_test("Apple Lion Release WK1 (Tests)", "userscripts/another-test.html", ["mac-lion-wk2"], "txt", None)
- self.assertMultiLineEqual(self._read('platform/mac-lion/userscripts/another-test-expected.txt'), self.MOCK_WEB_RESULT)
+ self.assertMultiLineEqual(self._read('platform/mac-lion-wk1/userscripts/another-test-expected.txt'), self.MOCK_WEB_RESULT)
self.assertFalse(self.tool.filesystem.exists(self._expand('platform/mac-lion-wk2/userscripts/another-test-expected.txt')))
def test_rebaseline_and_copy_test_with_lion_result(self):
@@ -185,8 +185,8 @@
self.command._rebaseline_test("Apple Lion Release WK1 (Tests)", "userscripts/another-test.html", ["mac-lion-wk2"], "txt", self.WEB_PREFIX)
self.assertItemsEqual(self.tool.web.urls_fetched, [self.WEB_PREFIX + '/userscripts/another-test-actual.txt'])
- self.assertMultiLineEqual(self._read("platform/mac-wk2/userscripts/another-test-expected.txt"), "original lion result")
- self.assertMultiLineEqual(self._read("platform/mac-lion/userscripts/another-test-expected.txt"), self.MOCK_WEB_RESULT)
+ self.assertMultiLineEqual(self._read("platform/mac-lion-wk2/userscripts/another-test-expected.txt"), "original lion result")
+ self.assertMultiLineEqual(self._read("platform/mac-lion-wk1/userscripts/another-test-expected.txt"), self.MOCK_WEB_RESULT)
def test_rebaseline_and_copy_no_overwrite_test(self):
self._write("platform/mac-lion/userscripts/another-test-expected.txt", "original lion result")
@@ -195,7 +195,7 @@
self.command._rebaseline_test("Apple Lion Release WK1 (Tests)", "userscripts/another-test.html", ["mac-lion-wk2"], "txt", None)
self.assertMultiLineEqual(self._read("platform/mac-lion-wk2/userscripts/another-test-expected.txt"), "original lion wk2 result")
- self.assertMultiLineEqual(self._read("platform/mac-lion/userscripts/another-test-expected.txt"), self.MOCK_WEB_RESULT)
+ self.assertMultiLineEqual(self._read("platform/mac-lion-wk1/userscripts/another-test-expected.txt"), self.MOCK_WEB_RESULT)
def test_rebaseline_test_internal_with_move_overwritten_baselines_to(self):
self.tool.executive = MockExecutive2()
_______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
