Title: [219587] trunk/Source/WebKit
- Revision
- 219587
- Author
- cdu...@apple.com
- Date
- 2017-07-17 16:55:22 -0700 (Mon, 17 Jul 2017)
Log Message
NETWORK_SESSION does not need didReceiveAuthenticationChallenge(uint64_t, uint64_t, const AuthenticationChallenge&)
https://bugs.webkit.org/show_bug.cgi?id=174595
Reviewed by Alex Christensen.
* Shared/Authentication/AuthenticationManager.cpp:
(WebKit::AuthenticationManager::didReceiveAuthenticationChallenge):
* Shared/Authentication/AuthenticationManager.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (219586 => 219587)
--- trunk/Source/WebKit/ChangeLog 2017-07-17 23:49:16 UTC (rev 219586)
+++ trunk/Source/WebKit/ChangeLog 2017-07-17 23:55:22 UTC (rev 219587)
@@ -1,3 +1,14 @@
+2017-07-17 Chris Dumez <cdu...@apple.com>
+
+ NETWORK_SESSION does not need didReceiveAuthenticationChallenge(uint64_t, uint64_t, const AuthenticationChallenge&)
+ https://bugs.webkit.org/show_bug.cgi?id=174595
+
+ Reviewed by Alex Christensen.
+
+ * Shared/Authentication/AuthenticationManager.cpp:
+ (WebKit::AuthenticationManager::didReceiveAuthenticationChallenge):
+ * Shared/Authentication/AuthenticationManager.h:
+
2017-07-17 Wenson Hsieh <wenson_hs...@apple.com>
[iOS DnD] Web process uses too much memory when beginning a drag on a very large image
Modified: trunk/Source/WebKit/Shared/Authentication/AuthenticationManager.cpp (219586 => 219587)
--- trunk/Source/WebKit/Shared/Authentication/AuthenticationManager.cpp 2017-07-17 23:49:16 UTC (rev 219586)
+++ trunk/Source/WebKit/Shared/Authentication/AuthenticationManager.cpp 2017-07-17 23:55:22 UTC (rev 219587)
@@ -156,16 +156,14 @@
pendingDownload.send(Messages::DownloadProxy::DidReceiveAuthenticationChallenge(authenticationChallenge, challengeID));
}
#endif
+
+#if !USE(NETWORK_SESSION)
void AuthenticationManager::didReceiveAuthenticationChallenge(uint64_t pageID, uint64_t frameID, const AuthenticationChallenge& authenticationChallenge)
{
ASSERT(pageID);
ASSERT(frameID);
- uint64_t challengeID = addChallengeToChallengeMap({pageID, authenticationChallenge
-#if USE(NETWORK_SESSION)
- , { }
-#endif
- });
+ uint64_t challengeID = addChallengeToChallengeMap({pageID, authenticationChallenge});
// Coalesce challenges in the same protection space and in the same page.
if (shouldCoalesceChallenge(pageID, challengeID, authenticationChallenge))
@@ -173,6 +171,7 @@
m_process->send(Messages::NetworkProcessProxy::DidReceiveAuthenticationChallenge(pageID, frameID, authenticationChallenge, challengeID));
}
+#endif
#if !USE(NETWORK_SESSION)
void AuthenticationManager::didReceiveAuthenticationChallenge(Download& download, const AuthenticationChallenge& authenticationChallenge)
Modified: trunk/Source/WebKit/Shared/Authentication/AuthenticationManager.h (219586 => 219587)
--- trunk/Source/WebKit/Shared/Authentication/AuthenticationManager.h 2017-07-17 23:49:16 UTC (rev 219586)
+++ trunk/Source/WebKit/Shared/Authentication/AuthenticationManager.h 2017-07-17 23:55:22 UTC (rev 219587)
@@ -72,9 +72,10 @@
#endif
// Called for resources in the WebProcess (NetworkProcess disabled)
void didReceiveAuthenticationChallenge(WebFrame*, const WebCore::AuthenticationChallenge&);
+
+#if !USE(NETWORK_SESSION)
// Called for resources in the NetworkProcess (NetworkProcess enabled)
void didReceiveAuthenticationChallenge(uint64_t pageID, uint64_t frameID, const WebCore::AuthenticationChallenge&);
-#if !USE(NETWORK_SESSION)
void didReceiveAuthenticationChallenge(Download&, const WebCore::AuthenticationChallenge&);
#endif
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
