Title: [219882] trunk/Tools
- Revision
- 219882
- Author
- commit-qu...@webkit.org
- Date
- 2017-07-25 13:50:19 -0700 (Tue, 25 Jul 2017)
Log Message
Fix autoinstaller failing on autoinstall_everything
https://bugs.webkit.org/show_bug.cgi?id=174830
Patch by Matthew Stewart <matthew_r_stew...@apple.com> on 2017-07-25
Reviewed by Joseph Pecoraro.
* Scripts/webkitpy/thirdparty/__init__.py:
(AutoinstallImportHook.find_module):
(AutoinstallImportHook.install_chromedriver):
(AutoinstallImportHook.install_geckodriver):
(AutoinstallImportHook._install_chromedriver): Deleted.
(AutoinstallImportHook._install_geckodriver): Deleted.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (219881 => 219882)
--- trunk/Tools/ChangeLog 2017-07-25 20:47:00 UTC (rev 219881)
+++ trunk/Tools/ChangeLog 2017-07-25 20:50:19 UTC (rev 219882)
@@ -1,3 +1,17 @@
+2017-07-25 Matthew Stewart <matthew_r_stew...@apple.com>
+
+ Fix autoinstaller failing on autoinstall_everything
+ https://bugs.webkit.org/show_bug.cgi?id=174830
+
+ Reviewed by Joseph Pecoraro.
+
+ * Scripts/webkitpy/thirdparty/__init__.py:
+ (AutoinstallImportHook.find_module):
+ (AutoinstallImportHook.install_chromedriver):
+ (AutoinstallImportHook.install_geckodriver):
+ (AutoinstallImportHook._install_chromedriver): Deleted.
+ (AutoinstallImportHook._install_geckodriver): Deleted.
+
2017-07-25 Jonathan Bedard <jbed...@apple.com>
Replace --runtime with something for both ios-simulator and ios-device
Modified: trunk/Tools/Scripts/webkitpy/thirdparty/__init__.py (219881 => 219882)
--- trunk/Tools/Scripts/webkitpy/thirdparty/__init__.py 2017-07-25 20:47:00 UTC (rev 219881)
+++ trunk/Tools/Scripts/webkitpy/thirdparty/__init__.py 2017-07-25 20:50:19 UTC (rev 219882)
@@ -103,9 +103,9 @@
elif '.selenium' in fullname:
self._install_selenium()
elif '.chromedriver' in fullname:
- self._install_chromedriver()
+ self.install_chromedriver()
elif '.geckodriver' in fullname:
- self._install_geckodriver()
+ self.install_geckodriver()
def _install_mechanize(self):
self._install("http://pypi.python.org/packages/source/m/mechanize/mechanize-0.2.5.tar.gz",
@@ -171,7 +171,7 @@
url, url_subpath = self.get_latest_pypi_url('selenium')
self._install(url="" url_subpath=url_subpath)
- def _install_chromedriver(self):
+ def install_chromedriver(self):
filename_postfix = get_driver_filename().chrome
if filename_postfix != "unsupported":
version = urllib2.urlopen(CHROME_DRIVER_URL + 'LATEST_RELEASE').read().strip()
@@ -178,7 +178,7 @@
full_chrome_url = "{base_url}{version}/chromedriver_{os}.zip".format(base_url=CHROME_DRIVER_URL, version=version, os=filename_postfix)
self.install_binary(full_chrome_url, 'chromedriver')
- def _install_geckodriver(self):
+ def install_geckodriver(self):
filename_postfix = get_driver_filename().firefox
if filename_postfix != "unsupported":
firefox_releases_blob = urllib2.urlopen(FIREFOX_RELEASES_URL)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
