Title: [221395] trunk/Source/WebCore
- Revision
- 221395
- Author
- commit-qu...@webkit.org
- Date
- 2017-08-30 13:19:17 -0700 (Wed, 30 Aug 2017)
Log Message
Add support for FetchRequest.body
https://bugs.webkit.org/show_bug.cgi?id=176066
<rdar://problem/34148373>
Patch by Youenn Fablet <you...@apple.com> on 2017-08-30
Reviewed by Sam Weinig and Alex Christensen.
Follow-up to https://trac.webkit.org/r221329 as per post landing comments.
Returning a RefPtr<ReadableStream> so as to to not specialize ReadableStream converter.
* Modules/fetch/FetchBodyOwner.cpp:
(WebCore::FetchBodyOwner::readableStream):
* Modules/fetch/FetchBodyOwner.h:
* bindings/js/ReadableStream.h:
(WebCore::toJS):
(WebCore::JSConverter<IDLInterface<ReadableStream>>::convert): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (221394 => 221395)
--- trunk/Source/WebCore/ChangeLog 2017-08-30 20:01:10 UTC (rev 221394)
+++ trunk/Source/WebCore/ChangeLog 2017-08-30 20:19:17 UTC (rev 221395)
@@ -1,3 +1,21 @@
+2017-08-30 Youenn Fablet <you...@apple.com>
+
+ Add support for FetchRequest.body
+ https://bugs.webkit.org/show_bug.cgi?id=176066
+ <rdar://problem/34148373>
+
+ Reviewed by Sam Weinig and Alex Christensen.
+
+ Follow-up to https://trac.webkit.org/r221329 as per post landing comments.
+ Returning a RefPtr<ReadableStream> so as to to not specialize ReadableStream converter.
+
+ * Modules/fetch/FetchBodyOwner.cpp:
+ (WebCore::FetchBodyOwner::readableStream):
+ * Modules/fetch/FetchBodyOwner.h:
+ * bindings/js/ReadableStream.h:
+ (WebCore::toJS):
+ (WebCore::JSConverter<IDLInterface<ReadableStream>>::convert): Deleted.
+
2017-08-30 Per Arne Vollan <pvol...@apple.com>
[Win] Crash in MathML layout test.
Modified: trunk/Source/WebCore/Modules/fetch/FetchBodyOwner.cpp (221394 => 221395)
--- trunk/Source/WebCore/Modules/fetch/FetchBodyOwner.cpp 2017-08-30 20:01:10 UTC (rev 221394)
+++ trunk/Source/WebCore/Modules/fetch/FetchBodyOwner.cpp 2017-08-30 20:19:17 UTC (rev 221395)
@@ -288,7 +288,7 @@
owner.blobLoadingFailed();
}
-ReadableStream* FetchBodyOwner::readableStream(JSC::ExecState& state)
+RefPtr<ReadableStream> FetchBodyOwner::readableStream(JSC::ExecState& state)
{
if (isBodyNull())
return nullptr;
Modified: trunk/Source/WebCore/Modules/fetch/FetchBodyOwner.h (221394 => 221395)
--- trunk/Source/WebCore/Modules/fetch/FetchBodyOwner.h 2017-08-30 20:01:10 UTC (rev 221394)
+++ trunk/Source/WebCore/Modules/fetch/FetchBodyOwner.h 2017-08-30 20:19:17 UTC (rev 221395)
@@ -57,7 +57,7 @@
bool isActive() const { return !!m_blobLoader; }
- ReadableStream* readableStream(JSC::ExecState&);
+ RefPtr<ReadableStream> readableStream(JSC::ExecState&);
virtual bool hasReadableStreamBody() const { return m_body && m_body->hasReadableStream(); }
protected:
Modified: trunk/Source/WebCore/bindings/js/ReadableStream.h (221394 => 221395)
--- trunk/Source/WebCore/bindings/js/ReadableStream.h 2017-08-30 20:01:10 UTC (rev 221394)
+++ trunk/Source/WebCore/bindings/js/ReadableStream.h 2017-08-30 20:19:17 UTC (rev 221395)
@@ -68,16 +68,9 @@
static constexpr bool needsState = true;
};
-template<> struct JSConverter<IDLInterface<ReadableStream>> {
- static constexpr bool needsState = false;
- static constexpr bool needsGlobalObject = false;
+inline JSC::JSValue toJS(JSC::ExecState*, JSC::JSGlobalObject*, ReadableStream* stream)
+{
+ return stream ? stream->readableStream() : JSC::jsUndefined();
+}
- static JSC::JSValue convert(ReadableStream* value)
- {
- if (!value)
- return JSC::jsNull();
- return value->readableStream();
- }
-};
-
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
