Title: [224631] trunk/Tools
Revision
224631
Author
bfulg...@apple.com
Date
2017-11-09 09:36:11 -0800 (Thu, 09 Nov 2017)

Log Message

Test fix after r224609
https://bugs.webkit.org/show_bug.cgi?id=178565
<rdar://problem/11115901>

Unreviewed test fix after r224609.

Correct two test cases that attempt to push local file URLs in violation of our
same origin policies. The fix is to grant universal file access, as we do for similar
LayoutTests.

* TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
(TestWebKitAPI::TEST):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (224630 => 224631)


--- trunk/Tools/ChangeLog	2017-11-09 17:20:27 UTC (rev 224630)
+++ trunk/Tools/ChangeLog	2017-11-09 17:36:11 UTC (rev 224631)
@@ -1,3 +1,20 @@
+2017-11-09  Brent Fulgham  <bfulg...@apple.com>
+
+        Test fix after r224609
+        https://bugs.webkit.org/show_bug.cgi?id=178565
+        <rdar://problem/11115901>
+
+        Unreviewed test fix after r224609.
+
+        Correct two test cases that attempt to push local file URLs in violation of our
+        same origin policies. The fix is to grant universal file access, as we do for similar
+        LayoutTests.
+
+        * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
+        (TestWebKitAPI::TEST):
+        * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
+        (TestWebKitAPI::TEST):
+
 2017-11-09  Michael Catanzaro  <mcatanz...@igalia.com>
 
         Unreviewed, remove Dan from the soup network watchlist

Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp (224630 => 224631)


--- trunk/Tools/TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp	2017-11-09 17:20:27 UTC (rev 224630)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp	2017-11-09 17:36:11 UTC (rev 224631)
@@ -30,6 +30,7 @@
 #include "PlatformUtilities.h"
 #include "PlatformWebView.h"
 #include "Test.h"
+#include <WebKit/WKPreferencesRefPrivate.h>
 #include <WebKit/WKRetainPtr.h>
 #include <WebKit/WKWebsiteDataStoreRef.h>
 
@@ -76,6 +77,12 @@
 
     WKPageSetPageLoaderClient(webView.page(), &pageLoaderClient.base);
 
+    WKRetainPtr<WKPreferencesRef> preferences(AdoptWK, WKPreferencesCreate());
+    WKPreferencesSetUniversalAccessFromFileURLsAllowed(preferences.get(), true);
+
+    WKPageGroupRef pageGroup = WKPageGetPageGroup(webView.page());
+    WKPageGroupSetPreferences(pageGroup, preferences.get());
+
     WKRetainPtr<WKURLRef> url(AdoptWK, Util::createURLForResource("push-state", "html"));
     WKPageLoadURL(webView.page(), url.get());
 

Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp (224630 => 224631)


--- trunk/Tools/TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp	2017-11-09 17:20:27 UTC (rev 224630)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp	2017-11-09 17:36:11 UTC (rev 224631)
@@ -30,6 +30,7 @@
 #include "PlatformUtilities.h"
 #include "PlatformWebView.h"
 #include "Test.h"
+#include <WebKit/WKPreferencesRefPrivate.h>
 #include <WebKit/WKRetainPtr.h>
 
 namespace TestWebKitAPI {
@@ -77,6 +78,7 @@
 
     WKRetainPtr<WKPreferencesRef> preferences(AdoptWK, WKPreferencesCreate());
     WKPreferencesSetPrivateBrowsingEnabled(preferences.get(), true);
+    WKPreferencesSetUniversalAccessFromFileURLsAllowed(preferences.get(), true);
 
     WKPageGroupRef pageGroup = WKPageGetPageGroup(webView.page());
     WKPageGroupSetPreferences(pageGroup, preferences.get());
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to