Title: [224633] trunk/Source/WebKit
- Revision
- 224633
- Author
- commit-qu...@webkit.org
- Date
- 2017-11-09 10:24:21 -0800 (Thu, 09 Nov 2017)
Log Message
ServiceWorkerClientFetch should create not null ResourceError
https://bugs.webkit.org/show_bug.cgi?id=179485
Patch by Youenn Fablet <you...@apple.com> on 2017-11-09
Reviewed by Darin Adler.
* WebProcess/Storage/ServiceWorkerClientFetch.cpp:
(WebKit::ServiceWorkerClientFetch::didReceiveResponse):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (224632 => 224633)
--- trunk/Source/WebKit/ChangeLog 2017-11-09 18:21:58 UTC (rev 224632)
+++ trunk/Source/WebKit/ChangeLog 2017-11-09 18:24:21 UTC (rev 224633)
@@ -1,3 +1,13 @@
+2017-11-09 Youenn Fablet <you...@apple.com>
+
+ ServiceWorkerClientFetch should create not null ResourceError
+ https://bugs.webkit.org/show_bug.cgi?id=179485
+
+ Reviewed by Darin Adler.
+
+ * WebProcess/Storage/ServiceWorkerClientFetch.cpp:
+ (WebKit::ServiceWorkerClientFetch::didReceiveResponse):
+
2017-11-09 Andy Estes <aes...@apple.com>
[iOS] Adopt UIPreviewDataAttachmentListIsContentManaged
Modified: trunk/Source/WebKit/WebProcess/Storage/ServiceWorkerClientFetch.cpp (224632 => 224633)
--- trunk/Source/WebKit/WebProcess/Storage/ServiceWorkerClientFetch.cpp 2017-11-09 18:21:58 UTC (rev 224632)
+++ trunk/Source/WebKit/WebProcess/Storage/ServiceWorkerClientFetch.cpp 2017-11-09 18:24:21 UTC (rev 224633)
@@ -53,7 +53,7 @@
if (!(response.httpStatusCode() <= 300 || response.httpStatusCode() >= 400 || response.httpStatusCode() == 304 || response.httpStatusCode() == 305 || response.httpStatusCode() == 306)) {
// FIXME: Support redirections.
notImplemented();
- m_loader->didFail({ });
+ m_loader->didFail({ ResourceError::Type::General });
if (auto callback = WTFMove(m_callback))
callback(Result::Succeeded);
return;
@@ -61,7 +61,7 @@
if (response.type() == ResourceResponse::Type::Error) {
// Add support for a better error.
- m_loader->didFail({ });
+ m_loader->didFail({ ResourceError::Type::General });
if (auto callback = WTFMove(m_callback))
callback(Result::Succeeded);
return;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
