Title: [224850] trunk/Source/WebCore
- Revision
- 224850
- Author
- achristen...@apple.com
- Date
- 2017-11-14 14:59:42 -0800 (Tue, 14 Nov 2017)
Log Message
Log moveFile failure errors
https://bugs.webkit.org/show_bug.cgi?id=179695
Reviewed by Brady Eidson.
Content extension tests are flaky. In r224790 I added logs to find out why, and they indicate that moveFile is failing.
To further understand why, I'm adding logs to see what's happening sometimes on the bots.
* platform/cocoa/FileSystemCocoa.mm:
(WebCore::FileSystem::moveFile):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (224849 => 224850)
--- trunk/Source/WebCore/ChangeLog 2017-11-14 22:31:50 UTC (rev 224849)
+++ trunk/Source/WebCore/ChangeLog 2017-11-14 22:59:42 UTC (rev 224850)
@@ -1,3 +1,16 @@
+2017-11-14 Alex Christensen <achristen...@webkit.org>
+
+ Log moveFile failure errors
+ https://bugs.webkit.org/show_bug.cgi?id=179695
+
+ Reviewed by Brady Eidson.
+
+ Content extension tests are flaky. In r224790 I added logs to find out why, and they indicate that moveFile is failing.
+ To further understand why, I'm adding logs to see what's happening sometimes on the bots.
+
+ * platform/cocoa/FileSystemCocoa.mm:
+ (WebCore::FileSystem::moveFile):
+
2017-11-14 Dean Jackson <d...@apple.com>
Fix Windows build.
Modified: trunk/Source/WebCore/platform/cocoa/FileSystemCocoa.mm (224849 => 224850)
--- trunk/Source/WebCore/platform/cocoa/FileSystemCocoa.mm 2017-11-14 22:31:50 UTC (rev 224849)
+++ trunk/Source/WebCore/platform/cocoa/FileSystemCocoa.mm 2017-11-14 22:59:42 UTC (rev 224850)
@@ -89,7 +89,11 @@
auto delegate = adoptNS([[WebFileManagerDelegate alloc] init]);
[manager setDelegate:delegate.get()];
- return [manager moveItemAtURL:[NSURL fileURLWithPath:oldPath] toURL:[NSURL fileURLWithPath:newPath] error:nil];
+ NSError *error = nil;
+ bool success = [manager moveItemAtURL:[NSURL fileURLWithPath:oldPath] toURL:[NSURL fileURLWithPath:newPath] error:&error];
+ if (!success)
+ NSLog(@"Error in moveFile: %@", error);
+ return success;
}
bool getVolumeFreeSpace(const String& path, uint64_t& freeSpace)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
