Title: [225510] trunk/Source/WebKit
Revision
225510
Author
beid...@apple.com
Date
2017-12-04 17:19:25 -0800 (Mon, 04 Dec 2017)

Log Message

Followup to:
Get a directory path to SWServers for storing ServiceWorker registrations
https://bugs.webkit.org/show_bug.cgi?id=180362

Unreviewed.


* StorageProcess/StorageProcess.cpp:
(WebKit::StorageProcess::swServerForSession): Change this ASSERT which is invalid in private browsing sessions.

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (225509 => 225510)


--- trunk/Source/WebKit/ChangeLog	2017-12-05 01:13:27 UTC (rev 225509)
+++ trunk/Source/WebKit/ChangeLog	2017-12-05 01:19:25 UTC (rev 225510)
@@ -1,3 +1,14 @@
+2017-12-04  Brady Eidson  <beid...@apple.com>
+
+        Followup to:
+        Get a directory path to SWServers for storing ServiceWorker registrations
+        https://bugs.webkit.org/show_bug.cgi?id=180362
+
+        Unreviewed.
+
+        * StorageProcess/StorageProcess.cpp:
+        (WebKit::StorageProcess::swServerForSession): Change this ASSERT which is invalid in private browsing sessions.
+
 2017-12-04  Simon Fraser  <simon.fra...@apple.com>
 
         Minor DisplayRefreshMonitor-related cleanup

Modified: trunk/Source/WebKit/StorageProcess/StorageProcess.cpp (225509 => 225510)


--- trunk/Source/WebKit/StorageProcess/StorageProcess.cpp	2017-12-05 01:13:27 UTC (rev 225509)
+++ trunk/Source/WebKit/StorageProcess/StorageProcess.cpp	2017-12-05 01:19:25 UTC (rev 225510)
@@ -387,7 +387,7 @@
     auto path = m_swDatabasePaths.get(sessionID);
     // There should already be a registered path for this PAL::SessionID.
     // If there's not, then where did this PAL::SessionID come from?
-    ASSERT(!path.isEmpty());
+    ASSERT(sessionID.isEphemeral() || !path.isEmpty());
 
     result.iterator->value = std::make_unique<SWServer>(makeUniqueRef<WebSWOriginStore>(), path);
     return *result.iterator->value;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to