Title: [225720] trunk/Source/WebKit
Revision
225720
Author
commit-qu...@webkit.org
Date
2017-12-08 21:36:37 -0800 (Fri, 08 Dec 2017)

Log Message

Service Worker should use a correct user agent
https://bugs.webkit.org/show_bug.cgi?id=180566
<rdar://problem/35926295>

Patch by Youenn Fablet <you...@apple.com> on 2017-12-08
Reviewed by Chris Dumez.

Addendum to landed patch.
This change was removed from the last version of the patch but proves to be needed by Safari.

* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::establishWorkerContextConnectionToStorageProcess):
Added back setting the user agent at start of service worker in case a page is already created.

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (225719 => 225720)


--- trunk/Source/WebKit/ChangeLog	2017-12-09 03:51:25 UTC (rev 225719)
+++ trunk/Source/WebKit/ChangeLog	2017-12-09 05:36:37 UTC (rev 225720)
@@ -1,3 +1,18 @@
+2017-12-08  Youenn Fablet  <you...@apple.com>
+
+        Service Worker should use a correct user agent
+        https://bugs.webkit.org/show_bug.cgi?id=180566
+        <rdar://problem/35926295>
+
+        Reviewed by Chris Dumez.
+
+        Addendum to landed patch.
+        This change was removed from the last version of the patch but proves to be needed by Safari.
+
+        * UIProcess/WebProcessPool.cpp:
+        (WebKit::WebProcessPool::establishWorkerContextConnectionToStorageProcess):
+        Added back setting the user agent at start of service worker in case a page is already created.
+
 2017-12-08  Brady Eidson  <beid...@apple.com>
 
         Delay some service worker operations until after the database import completes.

Modified: trunk/Source/WebKit/UIProcess/WebProcessPool.cpp (225719 => 225720)


--- trunk/Source/WebKit/UIProcess/WebProcessPool.cpp	2017-12-09 03:51:25 UTC (rev 225719)
+++ trunk/Source/WebKit/UIProcess/WebProcessPool.cpp	2017-12-09 05:36:37 UTC (rev 225720)
@@ -600,7 +600,10 @@
     m_serviceWorkerProcess = serviceWorkerProcessProxy.ptr();
     initializeNewWebProcess(serviceWorkerProcessProxy.get(), m_websiteDataStore->websiteDataStore());
     m_processes.append(WTFMove(serviceWorkerProcessProxy));
+
     m_serviceWorkerProcess->start(m_defaultPageGroup->preferences().store());
+    if (!m_serviceWorkerUserAgent.isNull())
+        m_serviceWorkerProcess->setUserAgent(m_serviceWorkerUserAgent);
 }
 #endif
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to