Diff
Modified: trunk/Source/WebCore/ChangeLog (227436 => 227437)
--- trunk/Source/WebCore/ChangeLog 2018-01-23 20:50:50 UTC (rev 227436)
+++ trunk/Source/WebCore/ChangeLog 2018-01-23 21:06:39 UTC (rev 227437)
@@ -1,3 +1,17 @@
+2018-01-23 Alex Christensen <achristen...@webkit.org>
+
+ Remove unused QTKit preference
+ https://bugs.webkit.org/show_bug.cgi?id=181968
+
+ Reviewed by Alexey Proskuryakov.
+
+ They weren't used and didn't do anything.
+
+ * page/DeprecatedGlobalSettings.cpp:
+ (WebCore::DeprecatedGlobalSettings::setQTKitEnabled): Deleted.
+ * page/DeprecatedGlobalSettings.h:
+ (WebCore::DeprecatedGlobalSettings::isQTKitEnabled): Deleted.
+
2018-01-23 Javier Fernandez <jfernan...@igalia.com>
[css-align] 'left' and 'right' should parse as invalid in block/cross-axis alignment
Modified: trunk/Source/WebCore/page/DeprecatedGlobalSettings.cpp (227436 => 227437)
--- trunk/Source/WebCore/page/DeprecatedGlobalSettings.cpp 2018-01-23 20:50:50 UTC (rev 227436)
+++ trunk/Source/WebCore/page/DeprecatedGlobalSettings.cpp 2018-01-23 21:06:39 UTC (rev 227437)
@@ -46,10 +46,6 @@
bool DeprecatedGlobalSettings::gAVFoundationNSURLSessionEnabled = true;
#endif
-#if PLATFORM(COCOA)
-bool DeprecatedGlobalSettings::gQTKitEnabled = false;
-#endif
-
#if USE(GSTREAMER)
bool DeprecatedGlobalSettings::gGStreamerEnabled = true;
#endif
@@ -105,17 +101,6 @@
}
#endif
-#if PLATFORM(COCOA)
-void DeprecatedGlobalSettings::setQTKitEnabled(bool enabled)
-{
- if (gQTKitEnabled == enabled)
- return;
-
- gQTKitEnabled = enabled;
- HTMLMediaElement::resetMediaEngines();
-}
-#endif
-
#if USE(GSTREAMER)
void DeprecatedGlobalSettings::setGStreamerEnabled(bool enabled)
{
Modified: trunk/Source/WebCore/page/DeprecatedGlobalSettings.h (227436 => 227437)
--- trunk/Source/WebCore/page/DeprecatedGlobalSettings.h 2018-01-23 20:50:50 UTC (rev 227436)
+++ trunk/Source/WebCore/page/DeprecatedGlobalSettings.h 2018-01-23 21:06:39 UTC (rev 227437)
@@ -55,13 +55,6 @@
static bool isAVFoundationNSURLSessionEnabled() { return gAVFoundationNSURLSessionEnabled; }
#endif
-#if PLATFORM(COCOA)
- WEBCORE_EXPORT static void setQTKitEnabled(bool flag);
- static bool isQTKitEnabled() { return gQTKitEnabled; }
-#else
- static bool isQTKitEnabled() { return false; }
-#endif
-
#if USE(GSTREAMER)
WEBCORE_EXPORT static void setGStreamerEnabled(bool flag);
static bool isGStreamerEnabled() { return gGStreamerEnabled; }
@@ -126,10 +119,6 @@
WEBCORE_EXPORT static bool gAVFoundationNSURLSessionEnabled;
#endif
-#if PLATFORM(COCOA)
- WEBCORE_EXPORT static bool gQTKitEnabled;
-#endif
-
#if USE(GSTREAMER)
WEBCORE_EXPORT static bool gGStreamerEnabled;
#endif
Modified: trunk/Source/WebKit/ChangeLog (227436 => 227437)
--- trunk/Source/WebKit/ChangeLog 2018-01-23 20:50:50 UTC (rev 227436)
+++ trunk/Source/WebKit/ChangeLog 2018-01-23 21:06:39 UTC (rev 227437)
@@ -1,3 +1,22 @@
+2018-01-23 Alex Christensen <achristen...@webkit.org>
+
+ Remove unused QTKit preference
+ https://bugs.webkit.org/show_bug.cgi?id=181968
+
+ Reviewed by Alexey Proskuryakov.
+
+ * Shared/API/c/WKDeprecatedFunctions.cpp:
+ (WKPreferencesSetQTKitEnabled):
+ (WKPreferencesGetQTKitEnabled):
+ * Shared/WebPreferences.yaml:
+ * UIProcess/API/C/WKPreferences.cpp:
+ (WKPreferencesSetQTKitEnabled): Deleted.
+ (WKPreferencesGetQTKitEnabled): Deleted.
+ * UIProcess/API/Cocoa/WKPreferences.mm:
+ (-[WKPreferences _setQTKitEnabled:]): Deleted.
+ (-[WKPreferences _qtKitEnabled]): Deleted.
+ * UIProcess/API/Cocoa/WKPreferencesPrivate.h:
+
2018-01-23 Brent Fulgham <bfulg...@apple.com>
[macOS] WebProcess needs TCC entitlements for media capture
Modified: trunk/Source/WebKit/Shared/API/c/WKDeprecatedFunctions.cpp (227436 => 227437)
--- trunk/Source/WebKit/Shared/API/c/WKDeprecatedFunctions.cpp 2018-01-23 20:50:50 UTC (rev 227436)
+++ trunk/Source/WebKit/Shared/API/c/WKDeprecatedFunctions.cpp 2018-01-23 21:06:39 UTC (rev 227437)
@@ -51,3 +51,12 @@
void WKContextSetProcessModel(WKContextRef, WKProcessModel)
{
}
+
+void WKPreferencesSetQTKitEnabled(WKPreferencesRef, bool)
+{
+}
+
+bool WKPreferencesGetQTKitEnabled(WKPreferencesRef)
+{
+ return false;
+}
Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml (227436 => 227437)
--- trunk/Source/WebKit/Shared/WebPreferences.yaml 2018-01-23 20:50:50 UTC (rev 227436)
+++ trunk/Source/WebKit/Shared/WebPreferences.yaml 2018-01-23 21:06:39 UTC (rev 227437)
@@ -415,13 +415,6 @@
type: bool
defaultValue: DEFAULT_TEMPORARY_TILE_COHORT_RETENTION_ENABLED
-QTKitEnabled:
- type: bool
- defaultValue: WebCore::DeprecatedGlobalSettings::isQTKitEnabled()
- getter: isQTKitEnabled
- webcoreBinding: DeprecatedGlobalSettings
- condition: PLATFORM(COCOA)
-
PageVisibilityBasedProcessSuppressionEnabled:
type: bool
defaultValue: true
Modified: trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp (227436 => 227437)
--- trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp 2018-01-23 20:50:50 UTC (rev 227436)
+++ trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp 2018-01-23 21:06:39 UTC (rev 227437)
@@ -1209,16 +1209,6 @@
return toImpl(preferencesRef)->aggressiveTileRetentionEnabled();
}
-void WKPreferencesSetQTKitEnabled(WKPreferencesRef preferencesRef, bool enabled)
-{
- toImpl(preferencesRef)->setQTKitEnabled(enabled);
-}
-
-bool WKPreferencesGetQTKitEnabled(WKPreferencesRef preferencesRef)
-{
- return toImpl(preferencesRef)->isQTKitEnabled();
-}
-
void WKPreferencesSetLogsPageMessagesToSystemConsoleEnabled(WKPreferencesRef preferencesRef, bool enabled)
{
toImpl(preferencesRef)->setLogsPageMessagesToSystemConsoleEnabled(enabled);
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm (227436 => 227437)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm 2018-01-23 20:50:50 UTC (rev 227436)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm 2018-01-23 21:06:39 UTC (rev 227437)
@@ -932,16 +932,6 @@
return _preferences->plugInSnapshottingEnabled();
}
-- (void)_setQTKitEnabled:(BOOL)enabled
-{
- _preferences->setQTKitEnabled(enabled);
-}
-
-- (BOOL)_qtKitEnabled
-{
- return _preferences->isQTKitEnabled();
-}
-
- (void)_setSubpixelCSSOMElementMetricsEnabled:(BOOL)enabled
{
_preferences->setSubpixelCSSOMElementMetricsEnabled(enabled);
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h (227436 => 227437)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h 2018-01-23 20:50:50 UTC (rev 227436)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h 2018-01-23 21:06:39 UTC (rev 227437)
@@ -154,7 +154,6 @@
@property (nonatomic, setter=_setArtificialPluginInitializationDelayEnabled:) BOOL _artificialPluginInitializationDelayEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA));
@property (nonatomic, setter=_setCookieEnabled:) BOOL _cookieEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA));
@property (nonatomic, setter=_setPlugInSnapshottingEnabled:) BOOL _plugInSnapshottingEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA));
-@property (nonatomic, setter=_setQTKitEnabled:) BOOL _qtKitEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA));
@property (nonatomic, setter=_setSubpixelCSSOMElementMetricsEnabled:) BOOL _subpixelCSSOMElementMetricsEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA));
@property (nonatomic, setter=_setMediaSourceEnabled:) BOOL _mediaSourceEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA));
@property (nonatomic, setter=_setViewGestureDebuggingEnabled:) BOOL _viewGestureDebuggingEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA));
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (227436 => 227437)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2018-01-23 20:50:50 UTC (rev 227436)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2018-01-23 21:06:39 UTC (rev 227437)
@@ -1,3 +1,19 @@
+2018-01-23 Alex Christensen <achristen...@webkit.org>
+
+ Remove unused QTKit preference
+ https://bugs.webkit.org/show_bug.cgi?id=181968
+
+ Reviewed by Alexey Proskuryakov.
+
+ * WebView/WebPreferenceKeysPrivate.h:
+ * WebView/WebPreferences.mm:
+ (+[WebPreferences initialize]):
+ (-[WebPreferences setQTKitEnabled:]): Deleted.
+ (-[WebPreferences isQTKitEnabled]): Deleted.
+ * WebView/WebPreferencesPrivate.h:
+ * WebView/WebView.mm:
+ (-[WebView _preferencesChanged:]):
+
2018-01-22 Wenson Hsieh <wenson_hs...@apple.com>
WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h (227436 => 227437)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h 2018-01-23 20:50:50 UTC (rev 227436)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h 2018-01-23 21:06:39 UTC (rev 227437)
@@ -157,7 +157,6 @@
#define WebKitDiagnosticLoggingEnabledKey @"WebKitDiagnosticLoggingEnabled"
#define WebKitStorageBlockingPolicyKey @"WebKitStorageBlockingPolicy"
#define WebKitPlugInSnapshottingEnabledPreferenceKey @"WebKitPlugInSnapshottingEnabled"
-#define WebKitQTKitEnabledPreferenceKey @"WebKitQTKitEnabled"
#define WebKitHiddenPageDOMTimerThrottlingEnabledPreferenceKey @"WebKitHiddenPageDOMTimerThrottlingEnabled"
#define WebKitHiddenPageCSSAnimationSuspensionEnabledPreferenceKey @"WebKitHiddenPageCSSAnimationSuspensionEnabled"
#define WebKitLowPowerVideoAudioBufferSizeEnabledPreferenceKey @"WebKitLowPowerVideoAudioBufferSizeEnabled"
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm (227436 => 227437)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm 2018-01-23 20:50:50 UTC (rev 227436)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm 2018-01-23 21:06:39 UTC (rev 227437)
@@ -597,7 +597,6 @@
#endif
[NSNumber numberWithLongLong:ApplicationCacheStorage::noQuota()], WebKitApplicationCacheTotalQuota,
[NSNumber numberWithLongLong:ApplicationCacheStorage::noQuota()], WebKitApplicationCacheDefaultOriginQuota,
- [NSNumber numberWithBool:DeprecatedGlobalSettings::isQTKitEnabled()], WebKitQTKitEnabledPreferenceKey,
[NSNumber numberWithBool:NO], WebKitHiddenPageDOMTimerThrottlingEnabledPreferenceKey,
[NSNumber numberWithBool:NO], WebKitHiddenPageCSSAnimationSuspensionEnabledPreferenceKey,
[NSNumber numberWithBool:NO], WebKitLowPowerVideoAudioBufferSizeEnabledPreferenceKey,
@@ -2265,16 +2264,6 @@
return [self _boolValueForKey:WebKitAVFoundationNSURLSessionEnabledKey];
}
-- (void)setQTKitEnabled:(BOOL)flag
-{
- [self _setBoolValue:flag forKey:WebKitQTKitEnabledPreferenceKey];
-}
-
-- (BOOL)isQTKitEnabled
-{
- return [self _boolValueForKey:WebKitQTKitEnabledPreferenceKey];
-}
-
- (void)setVideoPluginProxyEnabled:(BOOL)flag
{
// No-op, left for SPI compatibility.
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h (227436 => 227437)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h 2018-01-23 20:50:50 UTC (rev 227436)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h 2018-01-23 21:06:39 UTC (rev 227437)
@@ -423,9 +423,6 @@
- (void)setAVFoundationNSURLSessionEnabled:(BOOL)flag;
- (BOOL)isAVFoundationNSURLSessionEnabled;
-- (void)setQTKitEnabled:(BOOL)flag;
-- (BOOL)isQTKitEnabled;
-
// Deprecated, has no effect.
- (void)setVideoPluginProxyEnabled:(BOOL)flag;
- (BOOL)isVideoPluginProxyEnabled;
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebView.mm (227436 => 227437)
--- trunk/Source/WebKitLegacy/mac/WebView/WebView.mm 2018-01-23 20:50:50 UTC (rev 227436)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebView.mm 2018-01-23 21:06:39 UTC (rev 227437)
@@ -2935,7 +2935,6 @@
settings.setExperimentalNotificationsEnabled([preferences experimentalNotificationsEnabled]);
settings.setShowsURLsInToolTips([preferences showsURLsInToolTips]);
settings.setShowsToolTipOverTruncatedText([preferences showsToolTipOverTruncatedText]);
- DeprecatedGlobalSettings::setQTKitEnabled([preferences isQTKitEnabled]);
#endif // PLATFORM(MAC)
DatabaseManager::singleton().setIsAvailable([preferences databasesEnabled]);
