Title: [227530] trunk/Source/WebCore
- Revision
- 227530
- Author
- commit-qu...@webkit.org
- Date
- 2018-01-24 10:08:02 -0800 (Wed, 24 Jan 2018)
Log Message
Account for memory cache in DocumentThreadableLoader::didReceiveResponse assertion
https://bugs.webkit.org/show_bug.cgi?id=182049
Patch by Youenn Fablet <you...@apple.com> on 2018-01-24
Reviewed by Chris Dumez.
No change of behavior.
A response served from Service Worker may be cached in Memory Cache and reused later on.
Update DTL assertion to handle that case.
* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::didReceiveResponse):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (227529 => 227530)
--- trunk/Source/WebCore/ChangeLog 2018-01-24 18:07:18 UTC (rev 227529)
+++ trunk/Source/WebCore/ChangeLog 2018-01-24 18:08:02 UTC (rev 227530)
@@ -1,3 +1,17 @@
+2018-01-24 Youenn Fablet <you...@apple.com>
+
+ Account for memory cache in DocumentThreadableLoader::didReceiveResponse assertion
+ https://bugs.webkit.org/show_bug.cgi?id=182049
+
+ Reviewed by Chris Dumez.
+
+ No change of behavior.
+ A response served from Service Worker may be cached in Memory Cache and reused later on.
+ Update DTL assertion to handle that case.
+
+ * loader/DocumentThreadableLoader.cpp:
+ (WebCore::DocumentThreadableLoader::didReceiveResponse):
+
2018-01-24 Eric Carlson <eric.carl...@apple.com>
REGRESSION(r227457): Release assert in updateLayout while destructing a media element
Modified: trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp (227529 => 227530)
--- trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp 2018-01-24 18:07:18 UTC (rev 227529)
+++ trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp 2018-01-24 18:08:02 UTC (rev 227530)
@@ -334,7 +334,7 @@
}
return;
}
- ASSERT(response.type() == ResourceResponse::Type::Opaqueredirect || response.source() == ResourceResponse::Source::ServiceWorker);
+ ASSERT(response.type() == ResourceResponse::Type::Opaqueredirect || response.source() == ResourceResponse::Source::ServiceWorker || response.source() == ResourceResponse::Source::MemoryCache);
m_client->didReceiveResponse(identifier, response);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
