Title: [228879] trunk/Tools
- Revision
- 228879
- Author
- ms2...@igalia.com
- Date
- 2018-02-21 09:57:07 -0800 (Wed, 21 Feb 2018)
Log Message
[ATK] Remove attributeSet variable from AccessibilityUIElement::attributedStringForRange().
https://bugs.webkit.org/show_bug.cgi?id=183000
Reviewed by Joanmarie Diggs.
It is never initialized, but is passed to atk_attribute_set_free.
This caused a crash in accessibility/content-editable-as-textarea.html on the debug bots.
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::attributedStringForRange):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (228878 => 228879)
--- trunk/Tools/ChangeLog 2018-02-21 17:54:33 UTC (rev 228878)
+++ trunk/Tools/ChangeLog 2018-02-21 17:57:07 UTC (rev 228879)
@@ -1,3 +1,16 @@
+2018-02-21 Ms2ger <ms2...@igalia.com>
+
+ [ATK] Remove attributeSet variable from AccessibilityUIElement::attributedStringForRange().
+ https://bugs.webkit.org/show_bug.cgi?id=183000
+
+ Reviewed by Joanmarie Diggs.
+
+ It is never initialized, but is passed to atk_attribute_set_free.
+ This caused a crash in accessibility/content-editable-as-textarea.html on the debug bots.
+
+ * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
+ (WTR::AccessibilityUIElement::attributedStringForRange):
+
2018-02-21 Myles C. Maxfield <mmaxfi...@apple.com>
[Cocoa] Make system-ui obey the user-installed-font policy
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp (228878 => 228879)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp 2018-02-21 17:54:33 UTC (rev 228878)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp 2018-02-21 17:57:07 UTC (rev 228879)
@@ -1777,7 +1777,6 @@
builder.append(attributeSetToString(getAttributeSet(m_element.get(), TextAttributeType), "\n\t\t"));
// The attribute run provides attributes specific to the range of text at the specified offset.
- AtkAttributeSet* attributeSet;
AtkText* text = ATK_TEXT(m_element.get());
gint start = 0, end = 0;
for (unsigned i = location; i < location + length; i = end) {
@@ -1787,8 +1786,6 @@
builder.append(attributeSetToString(attributeSet, "\n\t\t"));
}
- atk_attribute_set_free(attributeSet);
-
return JSStringCreateWithUTF8CString(builder.toString().utf8().data());
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
