Title: [229499] trunk
- Revision
- 229499
- Author
- n_w...@apple.com
- Date
- 2018-03-09 19:37:13 -0800 (Fri, 09 Mar 2018)
Log Message
AX: AOM: More accessibility events support
https://bugs.webkit.org/show_bug.cgi?id=183023
<rdar://problem/37764380>
Reviewed by Chris Fleizach.
Source/WebCore:
The test is crashing when we call updateBackingStore when
the AXObjectCache object is gone. Added a check to fix that.
Modified the test by using the right format of setTimeout and extended the delay.
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::updateBackingStore):
LayoutTests:
* accessibility/mac/AOM-events-webarea-crash.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (229498 => 229499)
--- trunk/LayoutTests/ChangeLog 2018-03-10 03:10:41 UTC (rev 229498)
+++ trunk/LayoutTests/ChangeLog 2018-03-10 03:37:13 UTC (rev 229499)
@@ -1,3 +1,13 @@
+2018-03-09 Nan Wang <n_w...@apple.com>
+
+ AX: AOM: More accessibility events support
+ https://bugs.webkit.org/show_bug.cgi?id=183023
+ <rdar://problem/37764380>
+
+ Reviewed by Chris Fleizach.
+
+ * accessibility/mac/AOM-events-webarea-crash.html:
+
2018-03-09 Ryan Haddad <ryanhad...@apple.com>
Unreviewed, rolling out r229468.
Modified: trunk/LayoutTests/accessibility/mac/AOM-events-webarea-crash.html (229498 => 229499)
--- trunk/LayoutTests/accessibility/mac/AOM-events-webarea-crash.html 2018-03-10 03:10:41 UTC (rev 229498)
+++ trunk/LayoutTests/accessibility/mac/AOM-events-webarea-crash.html 2018-03-10 03:37:13 UTC (rev 229499)
@@ -19,7 +19,9 @@
webArea.takeFocus();
// make sure we don't crash after focusing onto the web area.
- setTimeout(finishJSTest(), 50);
+ setTimeout(function() {
+ finishJSTest();
+ }, 100);
}
</script>
Modified: trunk/Source/WebCore/ChangeLog (229498 => 229499)
--- trunk/Source/WebCore/ChangeLog 2018-03-10 03:10:41 UTC (rev 229498)
+++ trunk/Source/WebCore/ChangeLog 2018-03-10 03:37:13 UTC (rev 229499)
@@ -1,3 +1,19 @@
+2018-03-09 Nan Wang <n_w...@apple.com>
+
+ AX: AOM: More accessibility events support
+ https://bugs.webkit.org/show_bug.cgi?id=183023
+ <rdar://problem/37764380>
+
+ Reviewed by Chris Fleizach.
+
+ The test is crashing when we call updateBackingStore when
+ the AXObjectCache object is gone. Added a check to fix that.
+
+ Modified the test by using the right format of setTimeout and extended the delay.
+
+ * accessibility/AccessibilityObject.cpp:
+ (WebCore::AccessibilityObject::updateBackingStore):
+
2018-03-09 Ross Kirsling <ross.kirsl...@sony.com>
Unreviewed. Fix WinCairo build after r229497.
Modified: trunk/Source/WebCore/accessibility/AccessibilityObject.cpp (229498 => 229499)
--- trunk/Source/WebCore/accessibility/AccessibilityObject.cpp 2018-03-10 03:10:41 UTC (rev 229498)
+++ trunk/Source/WebCore/accessibility/AccessibilityObject.cpp 2018-03-10 03:37:13 UTC (rev 229499)
@@ -1777,6 +1777,9 @@
#if HAVE(ACCESSIBILITY)
void AccessibilityObject::updateBackingStore()
{
+ if (!axObjectCache())
+ return;
+
// Updating the layout may delete this object.
RefPtr<AccessibilityObject> protectedThis(this);
if (auto* document = this->document()) {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
