Title: [229941] trunk/Source/WebInspectorUI
- Revision
- 229941
- Author
- nvasil...@apple.com
- Date
- 2018-03-23 18:26:05 -0700 (Fri, 23 Mar 2018)
Log Message
Web Inspector: Styles: don't show checkboxes for invalid properties
https://bugs.webkit.org/show_bug.cgi?id=183951
<rdar://problem/38807602>
Reviewed by Matt Baker.
Since toggling of invalid properties isn't supported by the backend, don't show checkboxes for invalid properties.
* UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:
(.spreadsheet-css-declaration:matches(:hover, :focus) .property:not(:matches(.invalid-name, .invalid-value)) .property-toggle,):
(.spreadsheet-css-declaration:matches(:hover, :focus) .property-toggle,): Deleted.
Don't show checkboxes for invalid properties but still show them for duplicate properties.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (229940 => 229941)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-03-24 01:17:07 UTC (rev 229940)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-03-24 01:26:05 UTC (rev 229941)
@@ -1,3 +1,18 @@
+2018-03-23 Nikita Vasilyev <nvasil...@apple.com>
+
+ Web Inspector: Styles: don't show checkboxes for invalid properties
+ https://bugs.webkit.org/show_bug.cgi?id=183951
+ <rdar://problem/38807602>
+
+ Reviewed by Matt Baker.
+
+ Since toggling of invalid properties isn't supported by the backend, don't show checkboxes for invalid properties.
+
+ * UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:
+ (.spreadsheet-css-declaration:matches(:hover, :focus) .property:not(:matches(.invalid-name, .invalid-value)) .property-toggle,):
+ (.spreadsheet-css-declaration:matches(:hover, :focus) .property-toggle,): Deleted.
+ Don't show checkboxes for invalid properties but still show them for duplicate properties.
+
2018-03-23 Brian Burg <bb...@apple.com>
Web Inspector: add WebKitAdditions hooks for WebInspectorUI
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css (229940 => 229941)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css 2018-03-24 01:17:07 UTC (rev 229940)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css 2018-03-24 01:26:05 UTC (rev 229941)
@@ -68,7 +68,7 @@
margin: 0;
}
-.spreadsheet-css-declaration:matches(:hover, :focus) .property-toggle,
+.spreadsheet-css-declaration:matches(:hover, :focus) .property:not(:matches(.invalid-name, .invalid-value)) .property-toggle,
.spreadsheet-style-declaration-editor .property.disabled .property-toggle {
visibility: visible;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
