Title: [230089] trunk
- Revision
- 230089
- Author
- ryanhad...@apple.com
- Date
- 2018-03-29 18:24:00 -0700 (Thu, 29 Mar 2018)
Log Message
Unreviewed, rolling out r230087.
Introduced LayoutTest failures.
Reverted changeset:
"FrameSelection::appearanceUpdateTimerFired should be robust
against layout passes underneath it"
https://bugs.webkit.org/show_bug.cgi?id=183395
https://trac.webkit.org/changeset/230087
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (230088 => 230089)
--- trunk/LayoutTests/ChangeLog 2018-03-30 00:07:40 UTC (rev 230088)
+++ trunk/LayoutTests/ChangeLog 2018-03-30 01:24:00 UTC (rev 230089)
@@ -1,3 +1,16 @@
+2018-03-29 Ryan Haddad <ryanhad...@apple.com>
+
+ Unreviewed, rolling out r230087.
+
+ Introduced LayoutTest failures.
+
+ Reverted changeset:
+
+ "FrameSelection::appearanceUpdateTimerFired should be robust
+ against layout passes underneath it"
+ https://bugs.webkit.org/show_bug.cgi?id=183395
+ https://trac.webkit.org/changeset/230087
+
2018-03-29 Wenson Hsieh <wenson_hs...@apple.com>
FrameSelection::appearanceUpdateTimerFired should be robust against layout passes underneath it
Deleted: trunk/LayoutTests/editing/selection/iframe-update-selection-appearance-expected.txt (230088 => 230089)
--- trunk/LayoutTests/editing/selection/iframe-update-selection-appearance-expected.txt 2018-03-30 00:07:40 UTC (rev 230088)
+++ trunk/LayoutTests/editing/selection/iframe-update-selection-appearance-expected.txt 2018-03-30 01:24:00 UTC (rev 230089)
@@ -1,4 +0,0 @@
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/editing/selection/iframe-update-selection-appearance.html (230088 => 230089)
--- trunk/LayoutTests/editing/selection/iframe-update-selection-appearance.html 2018-03-30 00:07:40 UTC (rev 230088)
+++ trunk/LayoutTests/editing/selection/iframe-update-selection-appearance.html 2018-03-30 01:24:00 UTC (rev 230089)
@@ -1,32 +0,0 @@
-<!DOCTYPE html>
-<html lang="en">
-<head>
- <style>
- body { -webkit-user-modify: read-only; }
- </style>
- <script src=""
- <script>
- function reconnectSubframe() {
- document.body.appendChild(document.querySelector("iframe"));
- }
-
- function go() {
- jsTestIsAsync = true;
- if (window.finishJSTest)
- setTimeout(() => setTimeout(finishJSTest));
-
- getSelection().setPosition(document.body);
-
- if (window.internals)
- setTimeout(() => internals.setCaptionsStyleSheetOverride("* { }"));
-
- reconnectSubframe();
- }
- </script>
-</head>
-
-<body _onload_="go()">
- <iframe hidden="true"></iframe>
- <embed type="foobar" _onbeforeload_="reconnectSubframe()"></embed>
-</body>
-</html>
\ No newline at end of file
Modified: trunk/Source/WebCore/ChangeLog (230088 => 230089)
--- trunk/Source/WebCore/ChangeLog 2018-03-30 00:07:40 UTC (rev 230088)
+++ trunk/Source/WebCore/ChangeLog 2018-03-30 01:24:00 UTC (rev 230089)
@@ -1,3 +1,16 @@
+2018-03-29 Ryan Haddad <ryanhad...@apple.com>
+
+ Unreviewed, rolling out r230087.
+
+ Introduced LayoutTest failures.
+
+ Reverted changeset:
+
+ "FrameSelection::appearanceUpdateTimerFired should be robust
+ against layout passes underneath it"
+ https://bugs.webkit.org/show_bug.cgi?id=183395
+ https://trac.webkit.org/changeset/230087
+
2018-03-29 Wenson Hsieh <wenson_hs...@apple.com>
FrameSelection::appearanceUpdateTimerFired should be robust against layout passes underneath it
Modified: trunk/Source/WebCore/editing/FrameSelection.cpp (230088 => 230089)
--- trunk/Source/WebCore/editing/FrameSelection.cpp 2018-03-30 00:07:40 UTC (rev 230088)
+++ trunk/Source/WebCore/editing/FrameSelection.cpp 2018-03-30 01:24:00 UTC (rev 230089)
@@ -2441,10 +2441,6 @@
void FrameSelection::appearanceUpdateTimerFired()
{
- Ref<Frame> protectedFrame(*m_frame);
- if (auto* document = protectedFrame->document())
- document->updateLayoutIgnorePendingStylesheets();
-
updateAppearanceAfterLayoutOrStyleChange();
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
