Log Message
Resource Load Statistics: Apply cookie blocking to setCookiesFromDOM() https://bugs.webkit.org/show_bug.cgi?id=184346 <rdar://problem/39226036>
Reviewed by Brent Fulgham. Since these cookies can't be seen and are not sent in requests, I can't write an automated test for them. This really should have been done as part of: https://bugs.webkit.org/show_bug.cgi?id=180682. That said, I have tested this manually. * platform/network/mac/CookieJarMac.mm: (WebCore::setCookiesFromDOM):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (230318 => 230319)
--- trunk/Source/WebCore/ChangeLog 2018-04-06 02:12:26 UTC (rev 230318)
+++ trunk/Source/WebCore/ChangeLog 2018-04-06 02:25:41 UTC (rev 230319)
@@ -1,3 +1,19 @@
+2018-04-05 John Wilander <wilan...@apple.com>
+
+ Resource Load Statistics: Apply cookie blocking to setCookiesFromDOM()
+ https://bugs.webkit.org/show_bug.cgi?id=184346
+ <rdar://problem/39226036>
+
+ Reviewed by Brent Fulgham.
+
+ Since these cookies can't be seen and are not sent in requests, I
+ can't write an automated test for them. This really should have been
+ done as part of: https://bugs.webkit.org/show_bug.cgi?id=180682.
+ That said, I have tested this manually.
+
+ * platform/network/mac/CookieJarMac.mm:
+ (WebCore::setCookiesFromDOM):
+
2018-04-05 Zalan Bujtas <za...@apple.com>
Folding anonymous blocks should not result in deleting content.
Modified: trunk/Source/WebCore/platform/network/mac/CookieJarMac.mm (230318 => 230319)
--- trunk/Source/WebCore/platform/network/mac/CookieJarMac.mm 2018-04-06 02:12:26 UTC (rev 230318)
+++ trunk/Source/WebCore/platform/network/mac/CookieJarMac.mm 2018-04-06 02:25:41 UTC (rev 230319)
@@ -279,6 +279,9 @@
ASSERT([filteredCookies.get() count] <= 1);
#if HAVE(CFNETWORK_STORAGE_PARTITIONING)
+ if (session.shouldBlockCookies(firstParty, url))
+ return;
+
String partition = session.cookieStoragePartition(firstParty, url, frameID, pageID);
if (!partition.isEmpty())
filteredCookies = applyPartitionToCookies(partition, filteredCookies.get());
_______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
