Title: [230322] trunk/Websites/perf.webkit.org
- Revision
- 230322
- Author
- dewei_...@apple.com
- Date
- 2018-04-05 20:18:07 -0700 (Thu, 05 Apr 2018)
Log Message
Fix a bug introduced in r230295 that A/B test result is not shown.
https://bugs.webkit.org/show_bug.cgi?id=184350
Reviewed by Ryosuke Niwa.
result.label should be assigned in `TestGroup._computeRequestedCommitSets`.
* public/v3/models/test-group.js:
(TestGroup.prototype._computeRequestedCommitSets):
Modified Paths
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (230321 => 230322)
--- trunk/Websites/perf.webkit.org/ChangeLog 2018-04-06 03:10:20 UTC (rev 230321)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2018-04-06 03:18:07 UTC (rev 230322)
@@ -1,3 +1,15 @@
+2018-04-05 Dewei Zhu <dewei_...@apple.com>
+
+ Fix a bug introduced in r230295 that A/B test result is not shown.
+ https://bugs.webkit.org/show_bug.cgi?id=184350
+
+ Reviewed by Ryosuke Niwa.
+
+ result.label should be assigned in `TestGroup._computeRequestedCommitSets`.
+
+ * public/v3/models/test-group.js:
+ (TestGroup.prototype._computeRequestedCommitSets):
+
2018-03-29 Dewei Zhu <dewei_...@apple.com>
Added UI to show potential regressions in chart with t-testing against segmentations.
Modified: trunk/Websites/perf.webkit.org/public/v3/models/test-group.js (230321 => 230322)
--- trunk/Websites/perf.webkit.org/public/v3/models/test-group.js 2018-04-06 03:10:20 UTC (rev 230321)
+++ trunk/Websites/perf.webkit.org/public/v3/models/test-group.js 2018-04-06 03:18:07 UTC (rev 230322)
@@ -146,7 +146,7 @@
if (beforeValues.length && afterValues.length) {
const summary = metric.labelForDifference(beforeMean, afterMean, 'better', 'worse');
result.changeType = summary.changeType;
- result.changeLabel = summary.changeLabel;
+ result.label = summary.changeLabel;
var isSignificant = Statistics.testWelchsT(beforeValues, afterValues);
var significanceLabel = isSignificant ? 'significant' : 'insignificant';
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
