Title: [230855] trunk/LayoutTests
- Revision
- 230855
- Author
- n_w...@apple.com
- Date
- 2018-04-20 14:02:55 -0700 (Fri, 20 Apr 2018)
Log Message
Layout Test accessibility/mac/async-increment-decrement-action.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=184834
<rdar://problem/39604753>
Reviewed by Chris Fleizach.
Changed the test to just make sure the increment/decrement actions are async, that
they won't block the test by changing the object's value.
* accessibility/mac/async-increment-decrement-action-expected.txt:
* accessibility/mac/async-increment-decrement-action.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (230854 => 230855)
--- trunk/LayoutTests/ChangeLog 2018-04-20 21:01:40 UTC (rev 230854)
+++ trunk/LayoutTests/ChangeLog 2018-04-20 21:02:55 UTC (rev 230855)
@@ -1,3 +1,17 @@
+2018-04-20 Nan Wang <n_w...@apple.com>
+
+ Layout Test accessibility/mac/async-increment-decrement-action.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=184834
+ <rdar://problem/39604753>
+
+ Reviewed by Chris Fleizach.
+
+ Changed the test to just make sure the increment/decrement actions are async, that
+ they won't block the test by changing the object's value.
+
+ * accessibility/mac/async-increment-decrement-action-expected.txt:
+ * accessibility/mac/async-increment-decrement-action.html:
+
2018-04-20 Daniel Bates <daba...@apple.com>
Remove Strong Password decoration when text field type changes
Modified: trunk/LayoutTests/accessibility/mac/async-increment-decrement-action-expected.txt (230854 => 230855)
--- trunk/LayoutTests/accessibility/mac/async-increment-decrement-action-expected.txt 2018-04-20 21:01:40 UTC (rev 230854)
+++ trunk/LayoutTests/accessibility/mac/async-increment-decrement-action-expected.txt 2018-04-20 21:02:55 UTC (rev 230855)
@@ -5,10 +5,10 @@
PASS obj.intValue is 25
-PASS obj.intValue is 25
PASS obj.intValue is 50
-PASS obj.intValue is 50
PASS obj.intValue is 25
+PASS obj.intValue is 25
+PASS obj.intValue is 25
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/accessibility/mac/async-increment-decrement-action.html (230854 => 230855)
--- trunk/LayoutTests/accessibility/mac/async-increment-decrement-action.html 2018-04-20 21:01:40 UTC (rev 230854)
+++ trunk/LayoutTests/accessibility/mac/async-increment-decrement-action.html 2018-04-20 21:02:55 UTC (rev 230855)
@@ -15,26 +15,24 @@
description("This tests that increment and decrement actions are async.");
if (window.accessibilityController) {
- jsTestIsAsync = true;
var obj = accessibilityController.accessibleElementById("range1");
shouldBe("obj.intValue", "25");
+ // sync version
+ obj.increment();
+ shouldBe("obj.intValue", "50");
+ obj.decrement();
+ shouldBe("obj.intValue", "25");
+
+ // async version
+ // The increment/decrement actions are now async so that they won't
+ // block the test run loop by changing the value.
obj.asyncIncrement();
shouldBe("obj.intValue", "25");
-
- setTimeout(function() {
- shouldBe("obj.intValue", "50");
-
- obj.asyncDecrement();
- shouldBe("obj.intValue", "50");
-
- setTimeout(function() {
- shouldBe("obj.intValue", "25");
- finishJSTest();
- }, 5);
- }, 5);
+ obj.asyncDecrement();
+ shouldBe("obj.intValue", "25");
}
</script>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
