Title: [232008] trunk/Source/_javascript_Core
- Revision
- 232008
- Author
- fpi...@apple.com
- Date
- 2018-05-20 17:51:10 -0700 (Sun, 20 May 2018)
Log Message
Revert the B3 compiler pipeline's treatment of taildup
https://bugs.webkit.org/show_bug.cgi?id=185808
Reviewed by Yusuke Suzuki.
While trying to implement path specialization (bug 185060), I reorganized the B3 pass pipeline.
But then path specialization turned out to be a negative result. This reverts the pipeline to the
way it was before that work.
1.5% progression on V8Spider-CompileTime.
* b3/B3Generate.cpp:
(JSC::B3::generateToAir):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (232007 => 232008)
--- trunk/Source/_javascript_Core/ChangeLog 2018-05-20 22:21:02 UTC (rev 232007)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-05-21 00:51:10 UTC (rev 232008)
@@ -1,3 +1,19 @@
+2018-05-20 Filip Pizlo <fpi...@apple.com>
+
+ Revert the B3 compiler pipeline's treatment of taildup
+ https://bugs.webkit.org/show_bug.cgi?id=185808
+
+ Reviewed by Yusuke Suzuki.
+
+ While trying to implement path specialization (bug 185060), I reorganized the B3 pass pipeline.
+ But then path specialization turned out to be a negative result. This reverts the pipeline to the
+ way it was before that work.
+
+ 1.5% progression on V8Spider-CompileTime.
+
+ * b3/B3Generate.cpp:
+ (JSC::B3::generateToAir):
+
2018-05-20 Yusuke Suzuki <utatane....@gmail.com>
[DFG] CheckTypeInfoFlags should say `eliminated` if it is removed in constant folding phase
Modified: trunk/Source/_javascript_Core/b3/B3Generate.cpp (232007 => 232008)
--- trunk/Source/_javascript_Core/b3/B3Generate.cpp 2018-05-20 22:21:02 UTC (rev 232007)
+++ trunk/Source/_javascript_Core/b3/B3Generate.cpp 2018-05-21 00:51:10 UTC (rev 232008)
@@ -88,6 +88,10 @@
if (eliminateCommonSubexpressions(procedure))
eliminateCommonSubexpressions(procedure);
inferSwitches(procedure);
+ if (Options::useB3TailDup())
+ duplicateTails(procedure);
+ fixSSA(procedure);
+ foldPathConstants(procedure);
// FIXME: Add more optimizations here.
// https://bugs.webkit.org/show_bug.cgi?id=150507
@@ -101,11 +105,6 @@
if (procedure.optLevel() >= 2) {
reduceStrength(procedure);
- if (Options::useB3TailDup())
- duplicateTails(procedure);
- fixSSA(procedure);
- foldPathConstants(procedure);
- reduceStrength(procedure);
// FIXME: Add more optimizations here.
// https://bugs.webkit.org/show_bug.cgi?id=150507
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
