Title: [232789] trunk/Tools
- Revision
- 232789
- Author
- clo...@igalia.com
- Date
- 2018-06-13 03:50:29 -0700 (Wed, 13 Jun 2018)
Log Message
[JSCOnly] Add a MIPS32el JSCOnly EWS (follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=186523
Unreviewed follow-up fix after r232748
* Scripts/webkitpy/common/config/ports.py:
(JscOnlyPort.build_jsc_command): It is needed to pass a --jsc-only argument to the build-jsc script.
* Scripts/webkitpy/common/config/ports_unittest.py:
(DeprecatedPortTest.test_jsconly_port):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (232788 => 232789)
--- trunk/Tools/ChangeLog 2018-06-13 06:24:58 UTC (rev 232788)
+++ trunk/Tools/ChangeLog 2018-06-13 10:50:29 UTC (rev 232789)
@@ -1,3 +1,15 @@
+2018-06-13 Carlos Alberto Lopez Perez <clo...@igalia.com>
+
+ [JSCOnly] Add a MIPS32el JSCOnly EWS (follow-up fix)
+ https://bugs.webkit.org/show_bug.cgi?id=186523
+
+ Unreviewed follow-up fix after r232748
+
+ * Scripts/webkitpy/common/config/ports.py:
+ (JscOnlyPort.build_jsc_command): It is needed to pass a --jsc-only argument to the build-jsc script.
+ * Scripts/webkitpy/common/config/ports_unittest.py:
+ (DeprecatedPortTest.test_jsconly_port):
+
2018-06-12 Thibault Saunier <tsaun...@igalia.com>
webkitpy: Implement coredumpctl support on linux
Modified: trunk/Tools/Scripts/webkitpy/common/config/ports.py (232788 => 232789)
--- trunk/Tools/Scripts/webkitpy/common/config/ports.py 2018-06-13 06:24:58 UTC (rev 232788)
+++ trunk/Tools/Scripts/webkitpy/common/config/ports.py 2018-06-13 10:50:29 UTC (rev 232789)
@@ -238,4 +238,5 @@
def build_jsc_command(self, build_style=None):
command = self.script_shell_command("build-jsc")
+ command.append("--jsc-only")
return self._append_build_style_flag(command, build_style)
Modified: trunk/Tools/Scripts/webkitpy/common/config/ports_unittest.py (232788 => 232789)
--- trunk/Tools/Scripts/webkitpy/common/config/ports_unittest.py 2018-06-13 06:24:58 UTC (rev 232788)
+++ trunk/Tools/Scripts/webkitpy/common/config/ports_unittest.py 2018-06-13 10:50:29 UTC (rev 232789)
@@ -64,6 +64,6 @@
def test_jsconly_port(self):
self.assertEqual(JscOnlyPort().flag(), "--port=jsc-only")
- self.assertEqual(JscOnlyPort().build_jsc_command(), DeprecatedPort().script_shell_command("build-jsc"))
- self.assertEqual(JscOnlyPort().build_jsc_command(build_style="release"), DeprecatedPort().script_shell_command("build-jsc") + ["--release"])
- self.assertEqual(JscOnlyPort().build_jsc_command(build_style="debug"), DeprecatedPort().script_shell_command("build-jsc") + ["--debug"])
+ self.assertEqual(JscOnlyPort().build_jsc_command(), DeprecatedPort().script_shell_command("build-jsc") + ["--jsc-only"])
+ self.assertEqual(JscOnlyPort().build_jsc_command(build_style="release"), DeprecatedPort().script_shell_command("build-jsc") + ["--jsc-only", "--release"])
+ self.assertEqual(JscOnlyPort().build_jsc_command(build_style="debug"), DeprecatedPort().script_shell_command("build-jsc") + ["--jsc-only", "--debug"])
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
