Title: [233402] trunk/Tools
- Revision
- 233402
- Author
- mcatanz...@igalia.com
- Date
- 2018-06-30 14:07:50 -0700 (Sat, 30 Jun 2018)
Log Message
[CMake] build-webkit should be able to enable address sanitizer
https://bugs.webkit.org/show_bug.cgi?id=187222
Reviewed by Daniel Bates.
If 'set-webkit-configuration --asan' has been run, then build-webkit should pass
-DENABLE_ADDRESS_SANITIZER=ON to CMake, so that it actually does something.
This also works for build-jsc.
* Scripts/webkitdirs.pm:
(generateBuildSystemFromCMakeProject):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (233401 => 233402)
--- trunk/Tools/ChangeLog 2018-06-30 20:53:56 UTC (rev 233401)
+++ trunk/Tools/ChangeLog 2018-06-30 21:07:50 UTC (rev 233402)
@@ -1,3 +1,18 @@
+2018-06-30 Michael Catanzaro <mcatanz...@igalia.com>
+
+ [CMake] build-webkit should be able to enable address sanitizer
+ https://bugs.webkit.org/show_bug.cgi?id=187222
+
+ Reviewed by Daniel Bates.
+
+ If 'set-webkit-configuration --asan' has been run, then build-webkit should pass
+ -DENABLE_ADDRESS_SANITIZER=ON to CMake, so that it actually does something.
+
+ This also works for build-jsc.
+
+ * Scripts/webkitdirs.pm:
+ (generateBuildSystemFromCMakeProject):
+
2018-06-30 Thibault Saunier <tsaun...@igalia.com>
Make check_flatpak() not verbose when only trying to run command inside flatpak
Modified: trunk/Tools/Scripts/webkitdirs.pm (233401 => 233402)
--- trunk/Tools/Scripts/webkitdirs.pm 2018-06-30 20:53:56 UTC (rev 233401)
+++ trunk/Tools/Scripts/webkitdirs.pm 2018-06-30 21:07:50 UTC (rev 233402)
@@ -2252,6 +2252,8 @@
push @args, "-DCMAKE_BUILD_TYPE=Debug";
}
+ push @args, "-DENABLE_ADDRESS_SANITIZER=ON" if asanIsEnabled();
+
if ($willUseNinja) {
push @args, "-G";
if (canUseEclipseNinjaGenerator()) {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
