Title: [234024] trunk/Tools
- Revision
- 234024
- Author
- ross.kirsl...@sony.com
- Date
- 2018-07-19 23:10:34 -0700 (Thu, 19 Jul 2018)
Log Message
TestWTF.WTF.StringConcatenate_Unsigned fails for unsigned short on Windows
https://bugs.webkit.org/show_bug.cgi?id=187712
Reviewed by Fujii Hironori.
* TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
Mark result of unsigned short test case as platform-specific,
since Windows' behavior is actually *less* surprising here.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (234023 => 234024)
--- trunk/Tools/ChangeLog 2018-07-20 04:53:59 UTC (rev 234023)
+++ trunk/Tools/ChangeLog 2018-07-20 06:10:34 UTC (rev 234024)
@@ -1,3 +1,14 @@
+2018-07-19 Ross Kirsling <ross.kirsl...@sony.com>
+
+ TestWTF.WTF.StringConcatenate_Unsigned fails for unsigned short on Windows
+ https://bugs.webkit.org/show_bug.cgi?id=187712
+
+ Reviewed by Fujii Hironori.
+
+ * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
+ Mark result of unsigned short test case as platform-specific,
+ since Windows' behavior is actually *less* surprising here.
+
2018-07-19 Lucas Forschler <lforsch...@apple.com>
Teach the AWS Lambda to use the [minified]-platforms database
Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp (234023 => 234024)
--- trunk/Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp 2018-07-20 04:53:59 UTC (rev 234023)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp 2018-07-20 06:10:34 UTC (rev 234024)
@@ -81,7 +81,11 @@
EXPECT_EQ("hello 0 world", makeString("hello ", 0u , " world"));
EXPECT_EQ("hello 42 world", makeString("hello ", static_cast<unsigned char>(42) , " world"));
+#if PLATFORM(WIN)
+ EXPECT_EQ("hello 42 world", makeString("hello ", static_cast<unsigned short>(42) , " world"));
+#else
EXPECT_EQ("hello * world", makeString("hello ", static_cast<unsigned short>(42) , " world")); // Treated as a character.
+#endif
EXPECT_EQ("hello 4 world", makeString("hello ", sizeof(int) , " world")); // size_t
EXPECT_EQ("hello 4 world", makeString("hello ", offsetof(S, i) , " world")); // size_t
EXPECT_EQ("hello 3235839742 world", makeString("hello ", static_cast<size_t>(0xc0defefe), " world"));
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
