Title: [234621] trunk/LayoutTests
- Revision
- 234621
- Author
- rn...@webkit.org
- Date
- 2018-08-06 14:56:32 -0700 (Mon, 06 Aug 2018)
Log Message
fast/custom-elements/custom-element-registry-wrapper-should-stay-alive.html always timeouts on debug bots
https://bugs.webkit.org/show_bug.cgi?id=188353
Reviewed by Saam Barati.
Rely on GCController.collect() instead of allocating 1,000,000 objects in WebKitTestRunner / DumpRenderTree
so that debug builders won't timeout.
* fast/custom-elements/custom-element-registry-wrapper-should-stay-alive.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (234620 => 234621)
--- trunk/LayoutTests/ChangeLog 2018-08-06 21:08:53 UTC (rev 234620)
+++ trunk/LayoutTests/ChangeLog 2018-08-06 21:56:32 UTC (rev 234621)
@@ -3,6 +3,18 @@
fast/custom-elements/custom-element-registry-wrapper-should-stay-alive.html always timeouts on debug bots
https://bugs.webkit.org/show_bug.cgi?id=188353
+ Reviewed by Saam Barati.
+
+ Rely on GCController.collect() instead of allocating 1,000,000 objects in WebKitTestRunner / DumpRenderTree
+ so that debug builders won't timeout.
+
+ * fast/custom-elements/custom-element-registry-wrapper-should-stay-alive.html:
+
+2018-08-06 Ryosuke Niwa <rn...@webkit.org>
+
+ fast/custom-elements/custom-element-registry-wrapper-should-stay-alive.html always timeouts on debug bots
+ https://bugs.webkit.org/show_bug.cgi?id=188353
+
Add a timeout expectation to the test while I verify the fix for the test.
* TestExpectations:
Modified: trunk/LayoutTests/fast/custom-elements/custom-element-registry-wrapper-should-stay-alive.html (234620 => 234621)
--- trunk/LayoutTests/fast/custom-elements/custom-element-registry-wrapper-should-stay-alive.html 2018-08-06 21:08:53 UTC (rev 234620)
+++ trunk/LayoutTests/fast/custom-elements/custom-element-registry-wrapper-should-stay-alive.html 2018-08-06 21:56:32 UTC (rev 234621)
@@ -13,10 +13,12 @@
iframe.contentWindow.eval(`
window.customElements.someProperty = 'storedValue';
const a = [];
- for (let i = 0; i < 1000000; i++)
- a.push({});
if (window.GCController)
GCController.collect();
+ else {
+ for (let i = 0; i < 1000000; i++)
+ a.push({});
+ }
top.check(window.customElements.someProperty);`);
iframe.remove();
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
