Title: [234630] trunk/LayoutTests
- Revision
- 234630
- Author
- dba...@webkit.org
- Date
- 2018-08-06 15:23:24 -0700 (Mon, 06 Aug 2018)
Log Message
Setting table layout to fixed causes incorrect cell width calculations
https://bugs.webkit.org/show_bug.cgi?id=90068
Reviewed by Simon Fraser.
Derived from the test case written by Pravin D.
Add a test case to ensure we do not regress cell width computation in fixed table layout
when colspan is greater than the number of columns in the table.
* fast/table/fixed-table-layout/width-distribution-when-colspan-greater-than-table-columns-expected.html: Added.
* fast/table/fixed-table-layout/width-distribution-when-colspan-greater-than-table-columns.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (234629 => 234630)
--- trunk/LayoutTests/ChangeLog 2018-08-06 22:21:25 UTC (rev 234629)
+++ trunk/LayoutTests/ChangeLog 2018-08-06 22:23:24 UTC (rev 234630)
@@ -1,5 +1,20 @@
2018-08-06 Daniel Bates <daba...@apple.com>
+ Setting table layout to fixed causes incorrect cell width calculations
+ https://bugs.webkit.org/show_bug.cgi?id=90068
+
+ Reviewed by Simon Fraser.
+
+ Derived from the test case written by Pravin D.
+
+ Add a test case to ensure we do not regress cell width computation in fixed table layout
+ when colspan is greater than the number of columns in the table.
+
+ * fast/table/fixed-table-layout/width-distribution-when-colspan-greater-than-table-columns-expected.html: Added.
+ * fast/table/fixed-table-layout/width-distribution-when-colspan-greater-than-table-columns.html: Added.
+
+2018-08-06 Daniel Bates <daba...@apple.com>
+
Add tests to ensure that Same-Site cookies are stored when set as the first party
https://bugs.webkit.org/show_bug.cgi?id=188080
Added: trunk/LayoutTests/fast/table/fixed-table-layout/width-distribution-when-colspan-greater-than-table-columns-expected.html (0 => 234630)
--- trunk/LayoutTests/fast/table/fixed-table-layout/width-distribution-when-colspan-greater-than-table-columns-expected.html (rev 0)
+++ trunk/LayoutTests/fast/table/fixed-table-layout/width-distribution-when-colspan-greater-than-table-columns-expected.html 2018-08-06 22:23:24 UTC (rev 234630)
@@ -0,0 +1,38 @@
+<!DOCTYPE html>
+<html>
+<head>
+<style>
+table, tr, td {
+ border: 1px solid black;
+}
+
+td {
+ width: 1%;
+}
+table {
+ background: red;
+}
+tr {
+ background: green;
+ height: 35px;
+}
+</style>
+</head>
+<body>
+<p>This test verifies that the width of table cells are computed correctly in fixed table layout regardless of whether colspan > than the number of columns.</p>
+<table cellspacing="0" cellspacing="0" width="100%" style="table-layout: fixed;">
+ <tr>
+ <td></td>
+ <td></td>
+ <td></td>
+ <td></td>
+ <td></td>
+ <td></td>
+ <td style="width:94%;"></td>
+ </tr>
+ <tr>
+ <td colspan="7" style="height:24px;width:100%"></td>
+ </tr>
+</table>
+</body>
+</html>
Added: trunk/LayoutTests/fast/table/fixed-table-layout/width-distribution-when-colspan-greater-than-table-columns.html (0 => 234630)
--- trunk/LayoutTests/fast/table/fixed-table-layout/width-distribution-when-colspan-greater-than-table-columns.html (rev 0)
+++ trunk/LayoutTests/fast/table/fixed-table-layout/width-distribution-when-colspan-greater-than-table-columns.html 2018-08-06 22:23:24 UTC (rev 234630)
@@ -0,0 +1,38 @@
+<!DOCTYPE html>
+<html>
+<head>
+<style>
+table, tr, td {
+ border: 1px solid black;
+}
+
+td {
+ width: 1%;
+}
+table {
+ background: red;
+}
+tr {
+ background: green;
+ height: 35px;
+}
+</style>
+</head>
+<body>
+<p>This test verifies that the width of table cells are computed correctly in fixed table layout regardless of whether colspan > than the number of columns.</p>
+<table cellspacing="0" cellspacing="0" width="100%" style="table-layout: fixed;">
+ <tr>
+ <td></td>
+ <td></td>
+ <td></td>
+ <td></td>
+ <td></td>
+ <td></td>
+ <td style="width:94%;"></td>
+ </tr>
+ <tr>
+ <td colspan="10" style="height:24px;width:100%"></td>
+ </tr>
+</table>
+</body>
+</html>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
